From: Saul Wold <sgw@linux.intel.com>
To: Matthew McClintock <msm@freescale.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3] sysvinit-inittab_2.88dsf.bb: only run serial checks at boot if we have items to check
Date: Wed, 12 Sep 2012 10:17:47 -0700 [thread overview]
Message-ID: <5050C3BB.5030300@linux.intel.com> (raw)
In-Reply-To: <1347386213-6215-1-git-send-email-msm@freescale.com>
On 09/11/2012 10:56 AM, Matthew McClintock wrote:
> Right now, we delay running the serial console checks to we boot up. This causes
> issues for read only file systems. So, if have not configured any serial ports to
> check via SERIAL_CONSOLES_CHECK we can skip the check at boot. This fixes any
> issues with read only file systems and ipk packaging.
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> v2: bump PR
> v3: change a == bashism to =
>
> .../sysvinit/sysvinit-inittab_2.88dsf.bb | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb b/meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb
> index 1089edb..5b79caf 100644
> --- a/meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb
> +++ b/meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "Inittab for sysvinit"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
>
> -PR = "r7"
> +PR = "r8"
>
> SRC_URI = "file://inittab"
>
> @@ -54,7 +54,7 @@ EOF
>
> pkg_postinst_${PN} () {
> # run this on the target
> -if [ "x$D" == "x" ]; then
> +if [ "x$D" = "x" ]; then
> tmp="${SERIAL_CONSOLES_CHECK}"
> for i in $tmp
> do
> @@ -65,7 +65,11 @@ if [ "x$D" == "x" ]; then
> done
> kill -HUP 1
> else
> - exit 1
> + if [ "${SERIAL_CONSOLES_CHECK}" = "" ]; then
> + exit 0
> + else
> + exit 1
> + fi
> fi
> }
>
>
Merged to OE-Core
Thanks
Sau!
prev parent reply other threads:[~2012-09-12 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 17:56 [PATCH v3] sysvinit-inittab_2.88dsf.bb: only run serial checks at boot if we have items to check Matthew McClintock
2012-09-11 18:00 ` Phil Blundell
2012-09-12 17:17 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5050C3BB.5030300@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=msm@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.