From: Larry Finger <Larry.Finger@lwfinger.net>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, chaoming_li@realsil.com.cn
Subject: Re: [RFC/RFT 14/15] rtlwifi: Modify files for addition of rtl8723ae
Date: Thu, 13 Sep 2012 00:36:06 -0500 [thread overview]
Message-ID: <505170C6.8090003@lwfinger.net> (raw)
In-Reply-To: <CAGRGNgWezEzXV0-k6DA7TckNpa=zgN6LNv898N-PRU6P1LYgOw@mail.gmail.com>
On 09/12/2012 10:11 PM, Julian Calaby wrote:
> Hi Larry,
>
> On Thu, Sep 13, 2012 at 6:54 AM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>> This patch modifies the files of rtlwifi for the addition of a new driver
>> to handle the Realtek RTL8723AE wireless device, and introduces a new
>> routine to maintaim statistics that will be used later for roaming.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: <chaoming_li@realsil.com.cn>
>> ---
>> drivers/net/wireless/rtlwifi/debug.h | 2 +
>> drivers/net/wireless/rtlwifi/pci.h | 1 +
>> drivers/net/wireless/rtlwifi/stats.c | 274 ++++++++++++++++++++++++++++++++++
>> drivers/net/wireless/rtlwifi/stats.h | 47 ++++++
>> 4 files changed, 324 insertions(+)
>> create mode 100644 drivers/net/wireless/rtlwifi/stats.c
>> create mode 100644 drivers/net/wireless/rtlwifi/stats.h
>>
>> diff --git a/drivers/net/wireless/rtlwifi/debug.h b/drivers/net/wireless/rtlwifi/debug.h
>> index 07493d2..b81e299 100644
>> --- a/drivers/net/wireless/rtlwifi/debug.h
>> +++ b/drivers/net/wireless/rtlwifi/debug.h
>> @@ -106,6 +106,8 @@
>> #define COMP_REGD BIT(27)
>> #define COMP_CHAN BIT(28)
>> #define COMP_USB BIT(29)
>> +#define COMP_EASY_CONCURRENT BIT(29)
>
> Is this supposed to be bit #29 - I notice that COMP_USB is also bit 29.
Yes, that is OK. One will only be used for PCI-based drivers, and the other is
obviously for USB. As nearly all the bits of a 32-bit quantity are used, I
wanted to save one if possible.
In the final version, I'll code this as
#define COMP_USB BIT(29)
#define COMP_EASY_CONCURRENT COMP_USB
That way will be more obvious.
Larry
next prev parent reply other threads:[~2012-09-13 5:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 20:54 [RFC/RFT 00/15] Add new driver RTL8723AE Larry Finger
2012-09-12 20:54 ` Larry Finger
2012-09-12 20:54 ` [RFC/RFT 01/15] rtlwifi: rtl8723ae: Add new driver - Part 1 Larry Finger
2012-09-12 20:54 ` Larry Finger
2012-09-12 20:54 ` [RFC/RFT 02/15] rtlwifi: rtl8723ae: Add new driver - Part 2 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 03/15] rtlwifi: rtl8723ae: Add new driver - Part 3 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 04/15] rtlwifi: rtl8723ae: Add new driver - Part 4 Larry Finger
2012-09-12 20:54 ` Larry Finger
2012-09-12 20:54 ` [RFC/RFT 05/15] rtlwifi: rtl8723ae: Add new driver - Part 5 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 06/15] rtlwifi: rtl8723ae: Add new driver - Part 6 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 07/15] rtlwifi: rtl8723ae: Add new driver - Part 7 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 08/15] rtlwifi: rtl8723ae: Add new driver - Part 8 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 09/15] rtlwifi: rtl8723ae: Add new driver - Part 9 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 10/15] rtlwifi: rtl8723ae: Add new driver - Part 10 Larry Finger
2012-09-12 20:54 ` Larry Finger
2012-09-12 20:54 ` [RFC/RFT 11/15] rtlwifi: rtl8723ae: Add new driver - Part 11 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 12/15] rtlwifi: rtl8723ae: Add new driver - Part 12 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 13/15] rtlwifi: rtl8723ae: Add new driver - Part 13 Larry Finger
2012-09-12 20:54 ` Larry Finger
2012-09-12 20:54 ` [RFC/RFT 14/15] rtlwifi: Modify files for addition of rtl8723ae Larry Finger
2012-09-13 3:11 ` Julian Calaby
2012-09-13 5:36 ` Larry Finger [this message]
2012-09-14 6:10 ` Kalle Valo
2012-09-14 6:10 ` Kalle Valo
2012-09-12 20:54 ` [RFC/RFT 15/15] rtlwifi: rtl8192ce: rtl8192cu: rtl8192se: rtl81723ae: Turn on building of the new driver Larry Finger
2012-09-17 21:18 ` [PATCH 01/15] rtlwifi: rtl8723ae: Add new driver - Part 1 Larry Finger
2012-09-17 21:18 ` [PATCH 02/15] rtlwifi: rtl8723ae: Add new driver - Part 2 Larry Finger
2012-09-17 21:18 ` Larry Finger
2012-09-17 21:18 ` [PATCH 03/15] rtlwifi: rtl8723ae: Add new driver - Part 3 Larry Finger
2012-09-17 21:18 ` [PATCH 04/15] rtlwifi: rtl8723ae: Add new driver - Part 4 Larry Finger
2012-09-17 21:18 ` [PATCH 05/15] rtlwifi: rtl8723ae: Add new driver - Part 5 Larry Finger
2012-09-17 21:18 ` Larry Finger
2012-09-17 21:18 ` [PATCH 06/15] rtlwifi: rtl8723ae: Add new driver - Part 6 Larry Finger
2012-09-17 21:18 ` [PATCH 07/15] rtlwifi: rtl8723ae: Add new driver - Part 7 Larry Finger
2012-09-17 21:18 ` [PATCH 08/15] rtlwifi: rtl8723ae: Add new driver - Part 8 Larry Finger
2012-09-17 21:18 ` [PATCH 09/15] rtlwifi: rtl8723ae: Add new driver - Part 9 Larry Finger
2012-09-17 21:18 ` Larry Finger
2012-09-17 21:18 ` [PATCH 10/15] rtlwifi: rtl8723ae: Add new driver - Part 10 Larry Finger
2012-09-17 21:18 ` [PATCH 11/15] rtlwifi: rtl8723ae: Add new driver - Part 11 Larry Finger
2012-09-17 21:18 ` [PATCH 12/15] rtlwifi: rtl8723ae: Add new driver - Part 12 Larry Finger
2012-09-17 21:18 ` [PATCH 13/15] rtlwifi: rtl8723ae: Add new driver - Part 13 Larry Finger
2012-09-17 21:18 ` Larry Finger
2012-09-17 21:18 ` [PATCH 14/15] rtlwifi: Modify files for addition of rtl8723ae Larry Finger
2012-09-17 21:18 ` Larry Finger
2012-09-17 21:18 ` [PATCH 15/15] rtlwifi: rtl8192ce: rtl8192cu: rtl8192se: rtl81723ae: Turn on building of the new driver Larry Finger
2012-09-17 21:18 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505170C6.8090003@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.