From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH v4 3/8] cgroup: net_prio: Do not define task_netpioidx() when not selected Date: Thu, 13 Sep 2012 14:36:13 +0800 Message-ID: <50517EDD.4070007@huawei.com> References: <1347459128-32236-1-git-send-email-wagi@monom.org> <1347459128-32236-4-git-send-email-wagi@monom.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1347459128-32236-4-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Daniel Wagner Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Wagner , Gao feng , Jamal Hadi Salim , John Fastabend , Neil Horman On 2012/9/12 22:12, Daniel Wagner wrote: > From: Daniel Wagner > > task_netprioidx() should not be defined in case the configuration is > CONFIG_NETPRIO_CGROUP=n. The reason is that in a following patch the > net_prio_subsys_id will only be defined if CONFIG_NETPRIO_CGROUP!=n. > When net_prio is not built at all any callee should only get an empty > task_netprioidx() without any references to net_prio_subsys_id. > > Signed-off-by: Daniel Wagner > Acked-by: Tejun Heo > Cc: Gao feng > Cc: Jamal Hadi Salim > Cc: John Fastabend > Cc: Li Zefan > Cc: Neil Horman > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Acked-by: Li Zefan > --- > include/net/netprio_cgroup.h | 12 +++++------- > net/core/sock.c | 2 ++ > 2 files changed, 7 insertions(+), 7 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH v4 3/8] cgroup: net_prio: Do not define task_netpioidx() when not selected Date: Thu, 13 Sep 2012 14:36:13 +0800 Message-ID: <50517EDD.4070007@huawei.com> References: <1347459128-32236-1-git-send-email-wagi@monom.org> <1347459128-32236-4-git-send-email-wagi@monom.org> Mime-Version: 1.0 Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Cc: , , Daniel Wagner , Gao feng , Jamal Hadi Salim , John Fastabend , Neil Horman To: Daniel Wagner Return-path: In-Reply-To: <1347459128-32236-4-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 2012/9/12 22:12, Daniel Wagner wrote: > From: Daniel Wagner > > task_netprioidx() should not be defined in case the configuration is > CONFIG_NETPRIO_CGROUP=n. The reason is that in a following patch the > net_prio_subsys_id will only be defined if CONFIG_NETPRIO_CGROUP!=n. > When net_prio is not built at all any callee should only get an empty > task_netprioidx() without any references to net_prio_subsys_id. > > Signed-off-by: Daniel Wagner > Acked-by: Tejun Heo > Cc: Gao feng > Cc: Jamal Hadi Salim > Cc: John Fastabend > Cc: Li Zefan > Cc: Neil Horman > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Acked-by: Li Zefan > --- > include/net/netprio_cgroup.h | 12 +++++------- > net/core/sock.c | 2 ++ > 2 files changed, 7 insertions(+), 7 deletions(-)