From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 13 Sep 2012 08:48:12 +0200 (CEST) Received: from www.linutronix.de ([62.245.132.108]:60940 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1902243Ab2IMGsD (ORCPT ); Thu, 13 Sep 2012 08:48:03 +0200 Received: from localhost ([127.0.0.1]) by Galois.linutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1TC3Ce-0005AW-GH; Thu, 13 Sep 2012 08:47:08 +0200 Message-ID: <5051816A.3050705@linutronix.de> Date: Thu, 13 Sep 2012 08:47:06 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120817 Icedove/10.0.6 MIME-Version: 1.0 To: Rob Herring CC: Cyril Chemparathy , linux-mips@linux-mips.org, x86@kernel.org, a-jacquiot@ti.com, mahesh@linux.vnet.ibm.com, linus.walleij@linaro.org, grant.likely@secretlab.ca, paul.gortmaker@windriver.com, paulus@samba.org, hpa@zytor.com, m.szyprowski@samsung.com, jonas@southpole.se, linux@arm.linux.org.uk, linux-c6x-dev@linux-c6x.org, nico@linaro.org, david.daney@cavium.com, mingo@redhat.com, Geert Uytterhoeven , benh@kernel.crashing.org, suzuki@in.ibm.com, linux@openrisc.net, arnd@arndb.de, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, msalter@redhat.com, rob.herring@calxeda.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, blogic@openwrt.org, dhowells@redhat.com, monstr@monstr.eu, linux-kernel@vger.kernel.org, ralf@linux-mips.org, tj@kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] of: specify initrd location using 64-bit References: <1347465937-7056-1-git-send-email-cyril@ti.com> <5050CE33.9060909@ti.com> <5050E965.5080405@linutronix.de> <505107DF.5020105@gmail.com> In-Reply-To: <505107DF.5020105@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 X-archive-position: 34491 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: bigeasy@linutronix.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On 09/13/2012 12:08 AM, Rob Herring wrote: >> Geert is right here. If it is a physical address, it should be >> phys_addr_t. > > While generally true, for the DT specific code I think it should be a > fixed u64. The size of the address is defined by the FDT, not the > kernel. It is very likely we could have a FDT that specifies addresses > in 64-bit values, but then we boot a kernel is compiled for !LPAE. > phys_addr_t is currently sized based on LPAE setting. If your kernel is 32bit without PAE and your DTB address is >32ibt than you can't handle it. If you don't notice this in your dt code than you remap the wrong memory ioremap(). > > Rob > Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5051816A.3050705@linutronix.de> Date: Thu, 13 Sep 2012 08:47:06 +0200 From: Sebastian Andrzej Siewior MIME-Version: 1.0 To: Rob Herring Subject: Re: [PATCH] of: specify initrd location using 64-bit References: <1347465937-7056-1-git-send-email-cyril@ti.com> <5050CE33.9060909@ti.com> <5050E965.5080405@linutronix.de> <505107DF.5020105@gmail.com> In-Reply-To: <505107DF.5020105@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linux-mips@linux-mips.org, a-jacquiot@ti.com, mahesh@linux.vnet.ibm.com, linux@openrisc.net, paul.gortmaker@windriver.com, paulus@samba.org, hpa@zytor.com, m.szyprowski@samsung.com, jonas@southpole.se, linux@arm.linux.org.uk, linux-c6x-dev@linux-c6x.org, nico@linaro.org, x86@kernel.org, mingo@redhat.com, suzuki@in.ibm.com, Cyril Chemparathy , Geert Uytterhoeven , linus.walleij@linaro.org, arnd@arndb.de, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, msalter@redhat.com, rob.herring@calxeda.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, blogic@openwrt.org, dhowells@redhat.com, monstr@monstr.eu, david.daney@cavium.com, linux-kernel@vger.kernel.org, ralf@linux-mips.org, tj@kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09/13/2012 12:08 AM, Rob Herring wrote: >> Geert is right here. If it is a physical address, it should be >> phys_addr_t. > > While generally true, for the DT specific code I think it should be a > fixed u64. The size of the address is defined by the FDT, not the > kernel. It is very likely we could have a FDT that specifies addresses > in 64-bit values, but then we boot a kernel is compiled for !LPAE. > phys_addr_t is currently sized based on LPAE setting. If your kernel is 32bit without PAE and your DTB address is >32ibt than you can't handle it. If you don't notice this in your dt code than you remap the wrong memory ioremap(). > > Rob > Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: bigeasy@linutronix.de (Sebastian Andrzej Siewior) Date: Thu, 13 Sep 2012 08:47:06 +0200 Subject: [PATCH] of: specify initrd location using 64-bit In-Reply-To: <505107DF.5020105@gmail.com> References: <1347465937-7056-1-git-send-email-cyril@ti.com> <5050CE33.9060909@ti.com> <5050E965.5080405@linutronix.de> <505107DF.5020105@gmail.com> Message-ID: <5051816A.3050705@linutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/13/2012 12:08 AM, Rob Herring wrote: >> Geert is right here. If it is a physical address, it should be >> phys_addr_t. > > While generally true, for the DT specific code I think it should be a > fixed u64. The size of the address is defined by the FDT, not the > kernel. It is very likely we could have a FDT that specifies addresses > in 64-bit values, but then we boot a kernel is compiled for !LPAE. > phys_addr_t is currently sized based on LPAE setting. If your kernel is 32bit without PAE and your DTB address is >32ibt than you can't handle it. If you don't notice this in your dt code than you remap the wrong memory ioremap(). > > Rob > Sebastian