All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Rami Rosen <roszenrami@gmail.com>,
	Patrick McHardy <kaber@trash.net>, <netdev@vger.kernel.org>,
	Shlomo Pongratz <shlomop@mellanox.com>
Subject: Re: [PATCH net-next V3 1/2] IB/ipoib: Add rtnl_link_ops support
Date: Thu, 13 Sep 2012 13:54:59 +0300	[thread overview]
Message-ID: <5051BB83.3010103@mellanox.com> (raw)
In-Reply-To: <1347462823.13103.1085.camel@edumazet-glaptop>

On 12/09/2012 18:13, Eric Dumazet wrote:
> It might be related to module load/unload udevd or some external 
> daemon can access sysfs files while you unload the module 

Hi Eric,

I see, the IPoIB add/delete child sysfs handlers (ipoib_vlan_add/delete) 
use
RTNL locking to protect against netdev changes while the handlers are in 
action.

IPoIB uses devide_create_file to add the sysfs entries, but doesn't care 
to use
device_remove_file as these entries sit under the netdevice 
/sys/class/net/DEV
directory and are removed by higher layer when DEV gets 
unregistered/deleted, I'm
not sure if/how the driver is supposed to protect against access to 
these entries
while going down, when the module is unloaded, etc, any idea will be 
appreciated.


Or.

  reply	other threads:[~2012-09-13 11:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23 12:15 [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB Or Gerlitz
2012-08-23 12:15 ` [PATCH net-next V3 1/2] IB/ipoib: Add rtnl_link_ops support Or Gerlitz
2012-08-29 12:53   ` Patrick McHardy
2012-08-29 12:59     ` Or Gerlitz
2012-09-12 10:40     ` Or Gerlitz
2012-09-12 14:53       ` Rami Rosen
2012-09-12 15:13         ` Eric Dumazet
2012-09-13 10:54           ` Or Gerlitz [this message]
2012-09-13 11:28         ` Or Gerlitz
2012-08-23 12:15 ` [PATCH iproute2 2/2] iplink: added support for ipoib rtnl link ops Or Gerlitz
2012-09-04 17:48   ` Stephen Hemminger
2012-09-04 18:35     ` Or Gerlitz
2012-08-29  9:41 ` [PATCH net-next V3 0/2] Add rtnl_link_ops support to IPoIB Or Gerlitz
2012-08-29 12:45   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051BB83.3010103@mellanox.com \
    --to=ogerlitz@mellanox.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=roszenrami@gmail.com \
    --cc=shlomop@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.