From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH 3/5] KVM: MMU: Move gpte_access() out of paging_tmpl.h
Date: Thu, 13 Sep 2012 19:48:05 +0800
Message-ID: <5051C7F5.9050009@linux.vnet.ibm.com>
References: <1347460194-11807-1-git-send-email-avi@redhat.com> <1347460194-11807-4-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e28smtp04.in.ibm.com ([122.248.162.4]:53954 "EHLO
	e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757503Ab2IMLsN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 13 Sep 2012 07:48:13 -0400
Received: from /spool/local
	by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <xiaoguangrong@linux.vnet.ibm.com>;
	Thu, 13 Sep 2012 17:18:10 +0530
Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8DBm7DB2031886
	for <kvm@vger.kernel.org>; Thu, 13 Sep 2012 17:18:07 +0530
Received: from d28av03.in.ibm.com (loopback [127.0.0.1])
	by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8DBm6EB029729
	for <kvm@vger.kernel.org>; Thu, 13 Sep 2012 21:48:07 +1000
In-Reply-To: <1347460194-11807-4-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 09/12/2012 10:29 PM, Avi Kivity wrote:

>  static bool FNAME(is_last_gpte)(struct guest_walker *walker,
>  				struct kvm_vcpu *vcpu, struct kvm_mmu *mmu,
>  				pt_element_t gpte)
> @@ -217,7 +206,7 @@ retry_walk:
> 
>  		last_gpte = FNAME(is_last_gpte)(walker, vcpu, mmu, pte);
>  		if (last_gpte) {
> -			pte_access = pt_access & FNAME(gpte_access)(vcpu, pte);
> +			pte_access = pt_access & gpte_access(vcpu, pte);

It can pass 32bit variable to gpte_access without cast, no warning?