From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/5] KVM: MMU: Move gpte_access() out of paging_tmpl.h Date: Thu, 13 Sep 2012 14:50:31 +0300 Message-ID: <5051C887.1030707@redhat.com> References: <1347460194-11807-1-git-send-email-avi@redhat.com> <1347460194-11807-4-git-send-email-avi@redhat.com> <5051C7F5.9050009@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19889 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757623Ab2IMLuf (ORCPT ); Thu, 13 Sep 2012 07:50:35 -0400 In-Reply-To: <5051C7F5.9050009@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/13/2012 02:48 PM, Xiao Guangrong wrote: > On 09/12/2012 10:29 PM, Avi Kivity wrote: > >> static bool FNAME(is_last_gpte)(struct guest_walker *walker, >> struct kvm_vcpu *vcpu, struct kvm_mmu *mmu, >> pt_element_t gpte) >> @@ -217,7 +206,7 @@ retry_walk: >> >> last_gpte = FNAME(is_last_gpte)(walker, vcpu, mmu, pte); >> if (last_gpte) { >> - pte_access = pt_access & FNAME(gpte_access)(vcpu, pte); >> + pte_access = pt_access & gpte_access(vcpu, pte); > > It can pass 32bit variable to gpte_access without cast, no warning? No warning. -- error compiling committee.c: too many arguments to function