From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Date: Thu, 13 Sep 2012 16:01:40 +0400 Message-ID: <5051CB24.4010801@parallels.com> References: <20120910223125.GC7677@google.com> <20120910223355.GD7677@google.com> <20120911100433.GC8058@dhcp22.suse.cz> <5050568B.9090601@parallels.com> <20120912154907.GW21579@dhcp22.suse.cz> <20120912171120.GP7677@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120912171120.GP7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: Neil Horman , "Serge E. Hallyn" , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , Paul Mackerras , "Aneesh Kumar K.V" , Arnaldo Carvalho de Melo , Johannes Weiner , Thomas Graf , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Turner , Ingo Molnar , Vivek Goyal On 09/12/2012 09:11 PM, Tejun Heo wrote: > Hello, > > On Wed, Sep 12, 2012 at 05:49:07PM +0200, Michal Hocko wrote: >>> While I respect your goal of not warning about any configuration >>> with max_level = 1, I believe the only sane configuration as soon >>> as we get any 2nd-level child is use_hierarchy = 1 for everybody. >>> >>> Everything aside from it should be warned. >> >> Defintely. And that what the above guarantess, doesn't it? > > I'm getting a bit worried that I might not be fully understanding what > your concern is. Can you please elaborate what your worries are and > the transition plan that you have in your mind regarding > .use_hierarchy? > This is getting confusing for me as well, because I don't know if your reply was targeted towards me or Michal. As for me, I am in agreement with what you did, and I merely replied to Michal's concern and suggestion of not warning in the special 1-st level only setups saying I side with you.