From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Jeffrey Karrels <karrelsj@gmail.com>,
xen-devel@lists.xen.org
Subject: Re: Clang/LLVM version requirements
Date: Thu, 13 Sep 2012 14:40:32 +0200 [thread overview]
Message-ID: <5051D440.4000007@redhat.com> (raw)
In-Reply-To: <5051E531020000780009B083@nat28.tlf.novell.com>
Il 13/09/2012 13:52, Jan Beulich ha scritto:
>
> So the patch is fine by me if it covers that misalignment case.
> But it seems a little heavy handed - I'd think that instead of the
> sub-section, we could just create an arbitrary other section, or
> even allow uninitialized variable (it's unclear to me why Paolo
> wrote the comment - in c/s 25479:61dfb3da56b - regarding BSS
> the way it is now) - after all we only need to make sure that
> - the space gets properly allocated in trampoline.S, i.e. also in
> reloc.bin
> - all accesses are PC-relative
> Neither has anything to do with use of uninitialized variables.
We cannot use BSS because it doesn't appear in reloc.S.
Apart from BSS, there would be no benefit for reloc to move itself to
BOOT_TRAMPOLINE, because BOOT_TRAMPOLINE is not a known location
anymore. So it was easier to just run it in place from where we put it,
in the middle of head.S, but this means BSS disappears after extracting
reloc.bin.
So it's not really because the code must be relocatable, but more
because of the way we extract the binary data and put it in the middle
of head.S.
Initialized data works as long as you pass -fno-zero-initialized-in-bss
to the compiler or it is eaten. I used assembly to declare the alloc
variable, because I wasn't sure of which GCC versions need the option,
and whether older versions are supported for compiling Xen.
Paolo
next prev parent reply other threads:[~2012-09-13 12:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 22:32 Clang/LLVM version requirements Jeffrey Karrels
2012-09-07 8:50 ` Tim Deegan
2012-09-07 10:04 ` Jan Beulich
2012-09-13 10:11 ` Tim Deegan
2012-09-13 11:52 ` Jan Beulich
2012-09-13 12:21 ` Tim Deegan
2012-09-13 14:01 ` Jan Beulich
2012-09-13 14:55 ` Tim Deegan
2012-09-13 15:05 ` Keir Fraser
2012-09-13 15:09 ` Keir Fraser
2012-09-13 15:27 ` Ian Campbell
2012-09-13 15:51 ` Keir Fraser
2012-09-13 15:22 ` Jan Beulich
2012-09-13 15:34 ` Keir Fraser
2012-09-13 15:06 ` Jan Beulich
2012-09-13 12:40 ` Paolo Bonzini [this message]
2012-09-13 14:04 ` Jan Beulich
2012-09-13 14:13 ` Paolo Bonzini
2012-09-13 14:18 ` Jan Beulich
2012-09-07 15:58 ` Jeffrey Karrels
2012-09-11 18:43 ` Jeffrey Karrels
2012-09-12 10:24 ` Stefano Stabellini
2012-09-13 16:15 ` Ian Jackson
2012-09-13 16:41 ` Tim Deegan
2012-09-13 17:04 ` Ian Jackson
2012-09-12 10:31 ` Tim Deegan
2012-09-12 10:38 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051D440.4000007@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBeulich@suse.com \
--cc=karrelsj@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.