diff for duplicates of <5051EA85.1070000@bfs.de> diff --git a/a/1.txt b/N1/1.txt index d157495..c37751c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ Am 12.09.2012 17:06, schrieb Peter Senna Tschudin: > expression x; > @@ > -> if (x@p1 = NULL) { ... kfree@p2(x); ... return ...; } +> if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } > > @unchanged exists@ > position r.p1,r.p2; @@ -23,7 +23,7 @@ Am 12.09.2012 17:06, schrieb Peter Senna Tschudin: > statement S; > @@ > -> if (x@p1 = NULL) { ... when != I(x,...) S +> if (x@p1 == NULL) { ... when != I(x,...) S > when != e = e1 > when != e += e1 > when != e -= e1 @@ -40,7 +40,7 @@ Am 12.09.2012 17:06, schrieb Peter Senna Tschudin: > expression x; > @@ > -> ... when != true x@p1 = NULL +> ... when != true x@p1 == NULL > kfree@p2(x); > > @depends on !ok && unchanged@ @@ -65,7 +65,7 @@ Am 12.09.2012 17:06, schrieb Peter Senna Tschudin: > struct sdio_rx *r = NULL; > > r = kmalloc(sizeof(*r), GFP_ATOMIC); -> - if (r = NULL) +> - if (r == NULL) > - goto out; > + if (!r) > + return NULL; diff --git a/a/content_digest b/N1/content_digest index 2633d6f..4bdd094 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01347462407-13499-6-git-send-email-peter.senna@gmail.com\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [PATCH 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree\0" - "Date\0Thu, 13 Sep 2012 14:15:33 +0000\0" + "Date\0Thu, 13 Sep 2012 16:15:33 +0200\0" "To\0Peter Senna Tschudin <peter.senna@gmail.com>\0" "Cc\0Greg Kroah-Hartman <gregkh@linuxfoundation.org>" kernel-janitors@vger.kernel.org @@ -25,7 +25,7 @@ "> expression x;\n" "> @@\n" "> \n" - "> if (x@p1 = NULL) { ... kfree@p2(x); ... return ...; }\n" + "> if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }\n" "> \n" "> @unchanged exists@\n" "> position r.p1,r.p2;\n" @@ -34,7 +34,7 @@ "> statement S;\n" "> @@\n" "> \n" - "> if (x@p1 = NULL) { ... when != I(x,...) S\n" + "> if (x@p1 == NULL) { ... when != I(x,...) S\n" "> when != e = e1\n" "> when != e += e1\n" "> when != e -= e1\n" @@ -51,7 +51,7 @@ "> expression x;\n" "> @@\n" "> \n" - "> ... when != true x@p1 = NULL\n" + "> ... when != true x@p1 == NULL\n" "> kfree@p2(x);\n" "> \n" "> @depends on !ok && unchanged@\n" @@ -76,7 +76,7 @@ "> \tstruct sdio_rx *r = NULL;\n" "> \n" "> \tr = kmalloc(sizeof(*r), GFP_ATOMIC);\n" - "> -\tif (r = NULL)\n" + "> -\tif (r == NULL)\n" "> -\t\tgoto out;\n" "> +\tif (!r)\n" "> +\t\treturn NULL;\n" @@ -107,4 +107,4 @@ "> \n" > -b80dd92158b7a2ef958e9282d2a4474a55c3b41212231c61a6c54e5fa6d00193 +1293d7aab427fae3f117d9f9f7fa26d06fd49378a3a8d6f0e0b8d153c9fcb644
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.