Re: [Powertop] [PATCH] abstract_cpu: do not call total_pstate_time() in validate()

[Chris Ferron <chris.e.ferron at linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

On 09/13/2012 05:41 AM, Sergey Senozhatsky wrote:
>   abstract_cpu: do not call total_pstate_time() in validate()
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
>
> ---
>
>   src/cpu/abstract_cpu.cpp | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/src/cpu/abstract_cpu.cpp b/src/cpu/abstract_cpu.cpp
> index ebdc510..386d981 100644
> --- a/src/cpu/abstract_cpu.cpp
> +++ b/src/cpu/abstract_cpu.cpp
> @@ -414,15 +414,10 @@ uint64_t abstract_cpu::total_pstate_time(void)
>   void abstract_cpu::validate(void)
>   {
>   	unsigned int i;
> -	uint64_t my_time;
> -
> -	my_time = total_pstate_time();
>   
>   	for (i = 0; i < children.size(); i++) {
> -
> -		if (children[i]) {
> +		if (children[i])
>   			children[i]->validate();
> -		}
>   	}
>   }
>   
Your patch has been applied.
Thank You
-C