From: Jamal Hadi Salim <jhs@mojatatu.com>
To: David Ward <david.ward@ll.mit.edu>
Cc: netdev@vger.kernel.org, Bruce Osler <brosler@cisco.com>,
Cyril Chemparathy <cyril@ti.com>
Subject: Re: [PATCH 3/4] net_sched: gred: fix qave reporting via netlink
Date: Thu, 13 Sep 2012 14:01:59 -0400 [thread overview]
Message-ID: <50521F97.20503@mojatatu.com> (raw)
In-Reply-To: <1347549755-19438-3-git-send-email-david.ward@ll.mit.edu>
On 12-09-13 11:22 AM, David Ward wrote:
> q->vars.qavg is a Wlog scaled value, but q->backlog is not. In order
> to pass q->vars.qavg as the backlog value, we need to un-scale it.
> Additionally, the qave value returned via netlink should not be Wlog
> scaled, so we need to un-scale the result of red_calc_qavg().
>
> This caused artificially high values for "Average Queue" to be shown
> by 'tc -s -d qdisc', but did not affect the actual operation of GRED.
>
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
next prev parent reply other threads:[~2012-09-13 18:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 15:22 [PATCH 1/4] net_sched: gred: correct comment about qavg calculation in RIO mode David Ward
2012-09-13 15:22 ` [PATCH 2/4] net_sched: gred: eliminate redundant DP prio comparisons David Ward
2012-09-13 18:00 ` Jamal Hadi Salim
2012-09-13 20:10 ` David Miller
2012-09-13 15:22 ` [PATCH 3/4] net_sched: gred: fix qave reporting via netlink David Ward
2012-09-13 18:01 ` Jamal Hadi Salim [this message]
2012-09-13 20:10 ` David Miller
2012-09-13 15:22 ` [PATCH 4/4] net_sched: gred: actually perform idling in WRED mode David Ward
2012-09-13 18:08 ` Jamal Hadi Salim
2012-09-13 19:38 ` Ward, David - 0663 - MITLL
2012-09-13 20:10 ` David Miller
2012-09-13 20:37 ` Jamal Hadi Salim
2012-09-13 17:59 ` [PATCH 1/4] net_sched: gred: correct comment about qavg calculation in RIO mode Jamal Hadi Salim
2012-09-13 20:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50521F97.20503@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=brosler@cisco.com \
--cc=cyril@ti.com \
--cc=david.ward@ll.mit.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.