All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 9/9] Tegra30: Enable Cardhu build (SPL)
Date: Thu, 13 Sep 2012 16:47:30 -0600	[thread overview]
Message-ID: <50526282.8050603@wwwdotorg.org> (raw)
In-Reply-To: <1347487855-27077-10-git-send-email-twarren@nvidia.com>

On 09/12/2012 04:10 PM, Tom Warren wrote:
> This builds & boots to the command prompt on a Cardhu (T30) board.
> This is a barebones binary - no I2C, USB, MMC, SPI, etc.
> Drivers for those peripherals to follow.

> diff --git a/Makefile b/Makefile

>  ifeq ($(SOC),tegra20)
>  LIBS-y += arch/$(ARCH)/cpu/$(SOC)-common/lib$(SOC)-common.o
>  endif
> +ifeq ($(SOC),tegra30)
> +LIBS-y += arch/$(ARCH)/cpu/$(SOC)-common/lib$(SOC)-common.o
> +endif

To avoid adding more and more copies of that assignment, how about:

ifneq ($(filter $(SOC),tegra20 tegra30),)
LIBS-y += arch/$(ARCH)/cpu/$(SOC)-common/lib$(SOC)-common.o
endif

The same trick can be applied to the other two changes in this file, and
spl/Makefile.

Or perhaps you can just use:

ifneq ($(CONFIG_TEGRA),)

> diff --git a/drivers/gpio/tegra_gpio.c b/drivers/gpio/tegra_gpio.c

> +#if defined(CONFIG_TEGRA20)
>  #include <asm/arch/tegra20.h>
> +#else	/* Tegra30 */
> +#include <asm/arch/tegra30.h>
> +#endif

If that file got renamed to tegra.h in both places, you wouldn't need
ifdefs around the include.

  parent reply	other threads:[~2012-09-13 22:47 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 22:10 [U-Boot] [PATCH 0/9] Add basic Tegra30 (T30) support Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 1/9] Tegra: T30: Add include files Tom Warren
2012-09-13 18:06   ` Tom Rini
2012-09-13 21:10     ` Tom Warren
2012-09-18 19:29       ` Simon Glass
2012-09-18 21:07         ` Tom Warren
2012-09-13 19:35   ` Stephen Warren
2012-09-13 20:51     ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 2/9] Tegra: T30: Add AVP (arm720t) files Tom Warren
2012-09-13 20:02   ` Stephen Warren
2012-09-13 21:00     ` Tom Warren
2012-09-13 21:47       ` Lucas Stach
2012-09-13 22:06         ` Tom Warren
2012-09-18 19:37   ` Simon Glass
2012-09-18 21:19     ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 3/9] Tegra: T30: Add CPU (armv7) files Tom Warren
2012-09-13 20:03   ` Stephen Warren
2012-09-13 20:16     ` Tom Warren
2012-09-13 20:30       ` Stephen Warren
2012-09-13 20:33         ` Tom Rini
2012-09-13 21:21           ` Tom Warren
2012-09-13 22:04             ` Tom Rini
2012-09-13 22:16               ` Tom Warren
2012-09-13 22:28                 ` Tom Rini
2012-09-12 22:10 ` [U-Boot] [PATCH 4/9] Tegra: T30: Add common Tegra30 CPU files Tom Warren
2012-09-13 22:08   ` Stephen Warren
2012-09-18 19:40   ` Simon Glass
2012-09-12 22:10 ` [U-Boot] [PATCH 5/9] Tegra: DT: Add preliminary device tree files for T30 Cardhu Tom Warren
2012-09-13 22:14   ` Stephen Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 6/9] Tegra30: Add Cardhu board files Tom Warren
2012-09-13 22:23   ` Stephen Warren
2012-09-18 19:44   ` Simon Glass
2012-09-12 22:10 ` [U-Boot] [PATCH 7/9] Tegra30: Add config files (common and Cardhu) Tom Warren
2012-09-13 22:33   ` Stephen Warren
2012-09-13 22:45     ` Tom Rini
2012-09-13 23:38       ` Marek Vasut
2012-09-18 19:46   ` Simon Glass
2012-09-18 21:21     ` Tom Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 8/9] Tegra30: Add common pinmux config in board_early_init_f Tom Warren
2012-09-13 22:37   ` Stephen Warren
2012-09-18 19:53     ` Simon Glass
2012-09-18 21:32       ` Tom Warren
2012-09-18 21:53         ` Stephen Warren
2012-09-12 22:10 ` [U-Boot] [PATCH 9/9] Tegra30: Enable Cardhu build (SPL) Tom Warren
2012-09-13 18:00   ` Tom Rini
2012-09-13 20:02     ` Tom Warren
2012-09-13 22:47   ` Stephen Warren [this message]
2012-09-13 18:36 ` [U-Boot] [PATCH 0/9] Add basic Tegra30 (T30) support Stephen Warren
2012-09-13 21:04 ` Tom Rini
2012-09-13 21:25   ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50526282.8050603@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.