From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TCOIH-0006RH-E1
	for qemu-devel@nongnu.org; Fri, 14 Sep 2012 01:18:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TCOIG-0000Jr-L0
	for qemu-devel@nongnu.org; Fri, 14 Sep 2012 01:18:21 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TCOIG-0000Ja-Ef
	for qemu-devel@nongnu.org; Fri, 14 Sep 2012 01:18:20 -0400
Message-ID: <5052BE19.90909@weilnetz.de>
Date: Fri, 14 Sep 2012 07:18:17 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1347557866-7256-1-git-send-email-sw@weilnetz.de>
	<1347557866-7256-3-git-send-email-sw@weilnetz.de>
	<20120913212157.GA840@ohm.aurel32.net>
	<5052507C.7010603@twiddle.net>
	<20120913214742.GC6791@ohm.aurel32.net>
	<CAFEAcA_vvdF4zXcD2VyuR7wW+6kNMCn9yRzGdmKGOH8kP2aoBw@mail.gmail.com>
	<50525C4B.4060604@twiddle.net>
In-Reply-To: <50525C4B.4060604@twiddle.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] tcg/i386: Add shortcuts for registers
 used in L constraint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Alexander Graf <agraf@suse.de>

Am 14.09.2012 00:20, schrieb Richard Henderson:
> On 09/13/2012 03:03 PM, Peter Maydell wrote:
>> Hard to come up with a snappy name for "register which is the Nth
>> input argument if input args are in registers, but an arbitrary
>> temp reg otherwise, and which is in the forbidden list for the L
>> constraint"...
> I'm more than happy to let "register which is ..." be a comment
> just before the definitions of TCG_REG_Ln at the top...
>
>
>
> r~
>

This looks like a pragmatic solution.

If everybody agrees, I'll send an updated patch.

Or Aurelien or Blue can commit this series and fix the comment
as suggested by Richard. Maybe a comment in theprologue code
would also be good.

Thanks to all reviewers.

Stefan