All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Tao Ma <tm@tao.ma>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.
Date: Fri, 14 Sep 2012 08:43:56 -0500	[thread overview]
Message-ID: <5053349C.20106@sandeen.net> (raw)
In-Reply-To: <1347620592-3420-1-git-send-email-tm@tao.ma>

On 9/14/12 6:03 AM, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> After the volume is mkfsed, it should have no other files that
> need to be rmed. And what's more, it makes ext4 complain since
> lost+found is also removed.
> 
> So remove this useless "rm -rf $SCRATCH_MNT/*".

Oh, sigh, after all the review how did I miss that :/

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

SGI: I won't be pushing this to kernel.org trees per the emails yesterday.

Thanks,
-Eric

> Cc: Eric Sandeen <sandeen@sandeen.net>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
>  275 |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/275 b/275
> index 69b2895..06db775 100755
> --- a/275
> +++ b/275
> @@ -57,8 +57,6 @@ umount $SCRATCH_DEV 2>/dev/null
>  _scratch_mkfs_sized $((2 * 1024 * 1024 * 1024)) >>$seq.full 2>&1
>  _scratch_mount
>  
> -rm -rf $SCRATCH_MNT/*
> -
>  dd if=/dev/zero of=$SCRATCH_MNT/tmp1 bs=256K count=1 >>$seq.full 2>&1
>  [ $? -ne 0 ] && _fail "Error creating file"
>  
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-09-14 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 11:03 [PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT Tao Ma
2012-09-14 13:43 ` Eric Sandeen [this message]
2012-09-21 20:08 ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5053349C.20106@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=tm@tao.ma \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.