All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@sigma-star.at>
To: Richard Weinberger <richard@nod.at>, upstream@sigma-star.at
Cc: u-boot@lists.denx.de, upstream+uboot@sigma-star.at,
	patrick.delaunay@foss.st.com, marek.vasut+renesas@mailbox.org,
	yangshiji66@outlook.com, xypron.glpk@gmx.de,
	eugeneuriev@gmail.com, raymond.mao@linaro.org, devarsht@ti.com,
	bmeng.cn@gmail.com, trini@konsulko.com,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2] bootstage: Fix out-of-bounds read in reloc_bootstage()
Date: Thu, 01 Aug 2024 16:48:36 +0200	[thread overview]
Message-ID: <5054868.82XvGhxQ46@somecomputer> (raw)
In-Reply-To: <CAFLszThXjgSBHjUmbD1whpVnRvQO0rBXdYv60RS7DgXwrbzvKA@mail.gmail.com>

Simon,

Am Donnerstag, 1. August 2024, 16:42:14 CEST schrieb Simon Glass:
> > +       debug("Copying bootstage from %p to %p\n", gd->bootstage, to);
> > +       memcpy(to, gd->bootstage, sizeof(struct bootstage_data));
> > +       data = gd->bootstage = to;
> 
> should be a separate line (patman/checkpatch complains)

I saw the suggestion of checkpatch.pl but ditched it as matter of taste.
Do you want a v3?

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y



  reply	other threads:[~2024-08-01 14:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 16:07 [PATCH v2] bootstage: Fix out-of-bounds read in reloc_bootstage() Richard Weinberger
2024-08-01 14:42 ` Simon Glass
2024-08-01 14:48   ` Richard Weinberger [this message]
2024-08-01 16:14     ` Simon Glass
2024-08-16  3:47 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5054868.82XvGhxQ46@somecomputer \
    --to=richard@sigma-star.at \
    --cc=bmeng.cn@gmail.com \
    --cc=devarsht@ti.com \
    --cc=eugeneuriev@gmail.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=raymond.mao@linaro.org \
    --cc=richard@nod.at \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=upstream+uboot@sigma-star.at \
    --cc=upstream@sigma-star.at \
    --cc=xypron.glpk@gmx.de \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.