From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/5] KVM: MMU: Optimize is_last_gpte() Date: Sun, 16 Sep 2012 14:53:31 +0300 Message-ID: <5055BDBB.6080802@redhat.com> References: <1347460194-11807-1-git-send-email-avi@redhat.com> <1347472187-14708-1-git-send-email-avi@redhat.com> <5050CE7C.20206@redhat.com> <5051ABCA.8080300@redhat.com> <5051E205.5090400@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Xiao Guangrong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab2IPLxg (ORCPT ); Sun, 16 Sep 2012 07:53:36 -0400 In-Reply-To: <5051E205.5090400@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/13/2012 04:39 PM, Xiao Guangrong wrote: >> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h >> index 3318bde..f9a48cf 100644 >> --- a/arch/x86/include/asm/kvm_host.h >> +++ b/arch/x86/include/asm/kvm_host.h >> @@ -298,6 +298,13 @@ struct kvm_mmu { >> u64 *lm_root; >> u64 rsvd_bits_mask[2][4]; >> >> + /* >> + * Bitmap: bit set = last pte in walk >> + * index[0]: pte.ps >> + * index[1:2]: level >> + */ > > Opposite? index[2]: pte.pse? Yes. Fixed. -- error compiling committee.c: too many arguments to function