From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDETP-000639-7I
	for qemu-devel@nongnu.org; Sun, 16 Sep 2012 09:01:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDETO-0000a8-9T
	for qemu-devel@nongnu.org; Sun, 16 Sep 2012 09:01:19 -0400
Received: from cantor2.suse.de ([195.135.220.15]:50479 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDETO-0000a4-2v
	for qemu-devel@nongnu.org; Sun, 16 Sep 2012 09:01:18 -0400
Message-ID: <5055CD9A.4000504@suse.de>
Date: Sun, 16 Sep 2012 15:01:14 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1347740649-28646-1-git-send-email-rth@twiddle.net>
	<1347740649-28646-6-git-send-email-rth@twiddle.net>
In-Reply-To: <1347740649-28646-6-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org

Am 15.09.2012 22:24, schrieb Richard Henderson:
> Signed-off-by: Richard Henderson <rth@twiddle.net>

This is lacking a proper description. I'd be very ashamed if we lost
something so obvious during the QOM conversion. So what's the symptoms he=
re?

Andreas

> ---
>  target-alpha/translate.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
> index 12de6a3..f998f75 100644
> --- a/target-alpha/translate.c
> +++ b/target-alpha/translate.c
> @@ -3525,6 +3525,7 @@ static const struct cpu_def_t cpu_defs[] =3D {
> =20
>  CPUAlphaState * cpu_alpha_init (const char *cpu_model)
>  {
> +    static bool inited;
>      AlphaCPU *cpu;
>      CPUAlphaState *env;
>      int implver, amask, i, max;
> @@ -3532,7 +3533,10 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_=
model)
>      cpu =3D ALPHA_CPU(object_new(TYPE_ALPHA_CPU));
>      env =3D &cpu->env;
> =20
> -    alpha_translate_init();
> +    if (!inited) {
> +        inited =3D true;
> +        alpha_translate_init();
> +    }
> =20
>      /* Default to ev67; no reason not to emulate insns by default.  */
>      implver =3D IMPLVER_21264;
> @@ -3549,6 +3553,7 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_m=
odel)
>      }
>      env->implver =3D implver;
>      env->amask =3D amask;
> +    env->cpu_model_str =3D cpu_model;
> =20
>      qemu_init_vcpu(env);
>      return env;

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg