Re: [meta-webserver][PATCH 0/6] Add meta-webserver

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Wednesday 03 October 2012 15:12:55 Koen Kooi wrote:
> Op 3 okt. 2012, om 14:23 heeft Paul Eggleton <paul.eggleton@linux.intel.com> 
het volgende geschreven:
> > On Wednesday 03 October 2012 13:43:30 Koen Kooi wrote:
> >> Op 3 okt. 2012, om 13:29 heeft Paul Eggleton
> >> <paul.eggleton@linux.intel.com>> 
> > het volgende geschreven:
> >>> On Wednesday 03 October 2012 13:27:41 Koen Kooi wrote:
> >>>> Op 3 okt. 2012 om 12:43 heeft Paul Eggleton
> >>>> <paul.eggleton@linux.intel.com>
> >>> 
> >>> het volgende geschreven:
> >>>>> On Wednesday 03 October 2012 12:24:19 Koen Kooi wrote:
> >>>>>> Squash those "import" with the "fix" commits, no sense in having a
> >>>>>> broken
> >>>>>> recipe in there.
> >>>>> 
> >>>>> I'd rather not - there is sense in being clear about the changes,
> >>>>> because
> >>>>> there are a large number of them in this case.
> >>>> 
> >>>> The broken recipes are still available in OE classic if people want to
> >>>> compare them. I still don't get why you want to have broken recipes in
> >>>> the
> >>>> tree at multiple points in your series.
> >>> 
> >>> Because I want to easily see in "git blame" where particular lines came
> >>> from - did I add them, or have they been around for ages?
> >> 
> >> Does oe-core have the same flow for new recipes?
> > 
> > You already know the answer to this.
> 
> No I don't, actually.

The answer is no, it doesn't.

I guess on reflection we probably ought to be consistent here though - for 
better or worse, this is not what has been done when pulling in recipes from 
OE-Classic for the rest of meta-openembedded. The commit message does already 
list the changes from the original, and I'll concede that having just one 
revision doesn't give a huge amount in the way of insight on previous origin; 
ultimately as you say, OE-Classic is still there as a reference for that.

OK, I've squashed those commits out on the branch. Would it be worth me 
posting a v2 after all these changes?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre