From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDLLU-0004ns-Sc for qemu-devel@nongnu.org; Sun, 16 Sep 2012 16:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDLLT-00015s-NA for qemu-devel@nongnu.org; Sun, 16 Sep 2012 16:21:36 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:43227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDLLT-00015h-Ga for qemu-devel@nongnu.org; Sun, 16 Sep 2012 16:21:35 -0400 Message-ID: <505634CB.9050000@weilnetz.de> Date: Sun, 16 Sep 2012 22:21:31 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1342383972-11640-1-git-send-email-vapier@gentoo.org> <5003200B.4070400@weilnetz.de> <201209161552.08483.vapier@gentoo.org> In-Reply-To: <201209161552.08483.vapier@gentoo.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Frysinger Cc: Anthony Liguori , qemu-devel@nongnu.org, Sergei Trofimovich Am 16.09.2012 21:52, schrieb Mike Frysinger: > On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: >> Am 15.07.2012 22:26, schrieb Mike Frysinger: >>> We should not quote the PKG_CONFIG setting as this deviates from the >>> canonical upstream behavior that gets integrated with all other build >>> systems, and deviates from how we treat all other toolchain variables >>> that we get from the environment. >>> >>> Ultimately, the point is that it breaks passing custom flags directly >>> to pkg-config via the env var where this normally works elsewhere, >>> and it used to work in the past. > ping ... > -mike The complete discussion is here: http://patchwork.ozlabs.org/patch/171087/. I suggested using Mike's patch and removing commit 17884d7b6462b0fe497f08fec6091ffbe04caa8d. (./configure: request pkg-config to provide private libs when static linking). Anthony, Sergei, any comments? Regards Stefan