From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDWMa-0006ZG-91 for qemu-devel@nongnu.org; Mon, 17 Sep 2012 04:07:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDWMW-0006Lp-Bi for qemu-devel@nongnu.org; Mon, 17 Sep 2012 04:07:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDWAl-0001dA-KS for qemu-devel@nongnu.org; Mon, 17 Sep 2012 03:55:15 -0400 Message-ID: <5056D75C.5070401@redhat.com> Date: Mon, 17 Sep 2012 09:55:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1347755441-6499-1-git-send-email-vapier@gentoo.org> <5055A16F.4040303@redhat.com> <201209161603.24009.vapier@gentoo.org> In-Reply-To: <201209161603.24009.vapier@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Frysinger Cc: qemu-devel@nongnu.org Il 16/09/2012 22:03, Mike Frysinger ha scritto: >>> > > +ifeq ($(findstring clean,$(MAKECMDGOALS)),) >> > >> > Please use instead: >> > >> > ifneq ($(filter-out %clean,$(MAKECMDGOALS)),) >> > >> > so that "make clean all" still gives error. > that breaks `make` though. or rather, `make` no longer errors out. need to > make it a little more complicated to handle this. Perhaps MAKECMDGOALS ?= all does it? Paolo