From: "Andreas Färber" <afaerber@suse.de>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>
Cc: edgar.iglesias@gmail.com, crwulff@gmail.com,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC v0 09/10] microblaze_generic_fdt: first revision
Date: Mon, 17 Sep 2012 17:20:57 +0200 [thread overview]
Message-ID: <50573FD9.3030505@suse.de> (raw)
In-Reply-To: <368cdf3dac244fdf87e77855df93b7eb9463dc70.1347871922.git.peter.crosthwaite@petalogix.com>
Am 17.09.2012 11:03, schrieb Peter A. G. Crosthwaite:
> First revision of fdt generic platform for xilinx microblaze platforms.
> Adds machine model "microblaze-fdt" which can be used along with the --hw-dtb
> option to lauch dts driven machine models for microblaze platforms.
>
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> hw/microblaze/Makefile.objs | 1 +
> hw/microblaze_generic_fdt.c | 378 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 379 insertions(+), 0 deletions(-)
> create mode 100644 hw/microblaze_generic_fdt.c
>
> diff --git a/hw/microblaze/Makefile.objs b/hw/microblaze/Makefile.objs
> index ef2d6b7..be3aaa5 100644
> --- a/hw/microblaze/Makefile.objs
> +++ b/hw/microblaze/Makefile.objs
> @@ -1,5 +1,6 @@
> obj-y = petalogix_s3adsp1800_mmu.o
> obj-y += petalogix_ml605_mmu.o
> +obj-y += microblaze_generic_fdt.o
> obj-y += microblaze_boot.o
>
> obj-y += microblaze_pic_cpu.o
[snip]
Since this file clearly is MicroBlaze-specific, I suggest to place it in
hw/microblaze/generic_fdt.c instead. (CC'ing Mr. Makefile)
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-09-17 15:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 9:02 [Qemu-devel] [RFC v0 00/10] Microblaze generic FDT framework Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 01/10] device_tree: allow offsets for cell properties Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 02/10] device_tree: return Error* from prop getters Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 03/10] device_tree: allow property getters to inherit Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 04/10] device_tree: get_prop(): memdup returned properties Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 05/10] qemu-coroutine: Add simple work queue support Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 06/10] device_tree: Extended interface for fdt_generic Peter A. G. Crosthwaite
2012-09-17 9:02 ` [Qemu-devel] [RFC v0 07/10] fdt_generic: First revision Peter A. G. Crosthwaite
2012-09-17 9:48 ` Paolo Bonzini
2012-09-17 10:10 ` Peter Crosthwaite
2012-09-17 12:55 ` Paolo Bonzini
2012-09-17 9:03 ` [Qemu-devel] [RFC v0 08/10] pflash_cfi01: Added fdt generic platform support Peter A. G. Crosthwaite
2012-09-17 9:03 ` [Qemu-devel] [RFC v0 09/10] microblaze_generic_fdt: first revision Peter A. G. Crosthwaite
2012-09-17 15:20 ` Andreas Färber [this message]
2012-09-17 15:31 ` Paolo Bonzini
2012-09-17 9:03 ` [Qemu-devel] [RFC v0 10/10] serial: added fdt generic platform support Peter A. G. Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50573FD9.3030505@suse.de \
--to=afaerber@suse.de \
--cc=crwulff@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.