All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: kusmabite@gmail.com
Cc: git@vger.kernel.org, msysgit@googlegroups.com
Subject: Re: [PATCH/RFC] test-lib: add support for colors without tput
Date: Mon, 17 Sep 2012 19:39:36 +0200	[thread overview]
Message-ID: <50576058.4020508@kdbg.org> (raw)
In-Reply-To: <50536943.4030300@kdbg.org>

Am 14.09.2012 19:28, schrieb Johannes Sixt:
> Am 14.09.2012 18:58, schrieb Erik Faye-Lund:
>>  	tput () {
>>  		case "$1" in
>>  		bold)
>> -			echo -ne "\033[1m" ;;
>> +			printf "\033[1m" ;;
>>  		setaf)
>> -			echo -ne "\033[0;3$2m" ;;
>> +			printf "\033[0;3$2m" ;;
> 
> This should be
> 			printf '\033[0;3%sm' "$2" ;;
> 
>>  		sgr0)
>> -			echo -ne "\033(\033[m" ;;
>> +			printf "\033(\033[m" ;;
>>  		esac
>>  	}
>>  fi
> 
> Did you test this only in rxvt or in CMD as well? (I hadn't time to
> test, yet, so I'm asking :-)

I tested your patch with this fixup, and it works for me (in CMD).

-- Hannes

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

  parent reply	other threads:[~2012-09-17 17:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 16:41 [PATCH/RFC] test-lib: add support for colors without tput Erik Faye-Lund
2012-09-14 16:54 ` Erik Faye-Lund
2012-09-14 16:58   ` Erik Faye-Lund
2012-09-14 17:08     ` Elia Pinto
2012-09-14 17:11       ` Erik Faye-Lund
2012-09-14 17:12       ` Elia Pinto
2012-09-14 17:16         ` Erik Faye-Lund
2012-09-14 17:28     ` Johannes Sixt
2012-09-14 17:31       ` Erik Faye-Lund
2012-09-14 18:11       ` Erik Faye-Lund
2012-09-14 19:15         ` Johannes Sixt
2012-09-17 17:39       ` Johannes Sixt [this message]
2012-09-14 17:30   ` Junio C Hamano
2012-09-14 17:42     ` Erik Faye-Lund
2012-09-14 18:03       ` Junio C Hamano
2012-09-14 17:44 ` Jeff King
2012-09-14 17:52   ` Erik Faye-Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50576058.4020508@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=kusmabite@gmail.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.