All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <Anand.Jain@oracle.com>
To: Hugo Mills <hugo@carfax.org.uk>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs + Btrfs-progs:  make pipe functions re-usable
Date: Tue, 18 Sep 2012 11:39:39 +0800	[thread overview]
Message-ID: <5057ECFB.5000900@oracle.com> (raw)
In-Reply-To: <20120917102808.GE1129@carfax.org.uk>


>     As I said in our private email exchange some months ago, I don't
> think this is the right way to be doing this. For example, if you use
> an alternative tool (such as btrfs-gui) which uses the ioctls
> directly, you've lost that logging information.

  I agree with that Hugo. Thanks. These changes are partly for
  the same reason.

>     Keeping a log of what's been done to the FS is much better done by
> extending the available logging in the kernel

  Could you please point out the modules you are talking about.
  I reviewed some but just in case if I have missed out any.



Thanks,  Anand

  reply	other threads:[~2012-09-18  3:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  5:50 [PATCH] Btrfs + Btrfs-progs: make pipe functions re-usable anand jain
2012-09-14  6:04 ` [PATCH] Btrfs-progs: make dump_thread and write_buf usable outside cmds-send.c Anand jain
2012-09-14  6:04   ` [PATCH] Btrfs-progs: making send.h inline with its kernel side change Anand jain
2012-09-14  6:04   ` [PATCH] Btrfs: write_buf is now callable outside send.c Anand jain
2012-09-14 11:04 ` [PATCH] Btrfs + Btrfs-progs: make pipe functions re-usable David Sterba
2012-09-17  4:48   ` Anand Jain
2012-09-17 10:28     ` Hugo Mills
2012-09-18  3:39       ` Anand Jain [this message]
2012-09-17 14:59     ` David Sterba
2012-09-18  5:33       ` Anand Jain
2012-09-20 12:34         ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5057ECFB.5000900@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=hugo@carfax.org.uk \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.