From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 5/9] KVM: MMU: Optimize pte permission checks
Date: Tue, 18 Sep 2012 14:45:32 +0800
Message-ID: <5058188C.70006@linux.vnet.ibm.com>
References: <1347797235-20732-1-git-send-email-avi@redhat.com> <1347797235-20732-6-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:35289 "EHLO
	e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753321Ab2IRGpj (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 18 Sep 2012 02:45:39 -0400
Received: from /spool/local
	by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <xiaoguangrong@linux.vnet.ibm.com>;
	Tue, 18 Sep 2012 16:43:34 +1000
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8I6aJbR19136640
	for <kvm@vger.kernel.org>; Tue, 18 Sep 2012 16:36:20 +1000
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8I6jYEc007750
	for <kvm@vger.kernel.org>; Tue, 18 Sep 2012 16:45:34 +1000
In-Reply-To: <1347797235-20732-6-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 09/16/2012 08:07 PM, Avi Kivity wrote:

> @@ -3672,20 +3672,17 @@ static int vcpu_mmio_gva_to_gpa(struct kvm_vcpu *vcpu, unsigned long gva,
>  				gpa_t *gpa, struct x86_exception *exception,
>  				bool write)
>  {
> -	u32 access = (kvm_x86_ops->get_cpl(vcpu) == 3) ? PFERR_USER_MASK : 0;
> +	u32 access = ((kvm_x86_ops->get_cpl(vcpu) == 3) ? PFERR_USER_MASK : 0)
> +		| (write ? PFERR_WRITE_MASK : 0);
> 
> -	if (vcpu_match_mmio_gva(vcpu, gva) &&
> -		  check_write_user_access(vcpu, write, access,
> -		  vcpu->arch.access)) {
> +	if (vcpu_match_mmio_gva(vcpu, gva)
> +	    && permission_fault(vcpu->arch.walk_mmu, vcpu->arch.access, access)) {

I think '!' was missed? Is it !permission_fault()?

Otherwise looks good to me!

Reviewed-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>