All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] rebase -i: fix misleading error message after 'exec no-such' instruction
Date: Tue, 18 Sep 2012 13:29:34 +0200	[thread overview]
Message-ID: <50585B1E.6030900@viscovery.net> (raw)
In-Reply-To: <vpq7grrlgqy.fsf@grenoble-inp.fr>

Am 9/18/2012 13:20, schrieb Matthieu Moy:
> Johannes Sixt <j.sixt@viscovery.net> writes:
> 
>> From: Johannes Sixt <j6t@kdbg.org>
>>
>> When the todo sheet of interactive rebase instructs to run a non-existing
>> command, the operation stops with the following error:
>>
>>   Execution failed: no-such
>>   You can fix the problem, and then run
>>
>>           git rebase --continue
>>
>>   fatal: 'rebase' appears to be a git command, but we were not
>>   able to execute it. Maybe git-rebase is broken?
> 
> While you're there, maybe you want to turn the first line into
> 
> Execution failed: no-such (command not found)

No, I don't want to: Neither do we have errno here, nor can we be specific
enough because the whole shell script the user gave after 'exec' is
repeated here.

I would rather remove the line so that it does not distract from the more
specific error message that the shell gave. On top of that, the command is
already dumped before it is executed; we don't need to repeat it.

-- Hannes

  reply	other threads:[~2012-09-18 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 11:15 [PATCH] rebase -i: fix misleading error message after 'exec no-such' instruction Johannes Sixt
2012-09-18 11:20 ` Matthieu Moy
2012-09-18 11:29   ` Johannes Sixt [this message]
2012-09-18 11:38     ` Matthieu Moy
2012-09-18 20:29 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50585B1E.6030900@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.