From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TDwwG-0001eE-16
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:30:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TDww9-0006o6-HJ
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:30:03 -0400
Message-ID: <5058693B.9020103@msgid.tls.msk.ru>
Date: Tue, 18 Sep 2012 16:29:47 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1339086183-1356-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1339086183-1356-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix
 target path in generated dependency file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Has it been applied to anything?  I don't think so.
Is it still needed?

Thanks,

/mjt

On 07.06.2012 20:23, Andreas F=C3=A4rber wrote:
> config-devices.mak.d is included from Makefile.target, i.e. from inside
> the *-softmmu/ directory. It included the directory path, so never
> applied to the actual config-devices.mak. Symptoms were spurious
> dependency issues with default-configs/pci.mak.
>=20
> Fix by using `basename` to strip the directory path.
>=20
> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  Seems I forgot to send this out before 1.1...
>=20
>  scripts/make_device_config.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config=
.sh
> index 5d14885..0778fe2 100644
> --- a/scripts/make_device_config.sh
> +++ b/scripts/make_device_config.sh
> @@ -25,4 +25,4 @@ done
>  process_includes $src > $dest
> =20
>  cat $src $all_includes | grep -v '^include' > $dest
> -echo "$1: $all_includes" > $dep
> +echo "`basename $1`: $all_includes" > $dep