From: Kevin Wolf <kwolf@redhat.com>
To: bharata@linux.vnet.ibm.com
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Anand Avati <aavati@redhat.com>,
Vijay Bellur <vbellur@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Amar Tumballi <amarts@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.
Date: Tue, 18 Sep 2012 14:47:59 +0200 [thread overview]
Message-ID: <50586D7F.8060307@redhat.com> (raw)
In-Reply-To: <20120917152249.GC6879@in.ibm.com>
Am 17.09.2012 17:22, schrieb Bharata B Rao:
> sockets: Make inet_parse() non static.
>
> From: Bharata B Rao <bharata@linux.vnet.ibm.com>
>
> Make inet_parse() non-static so that other subsystems like gluster
> can use it to parse inet addresses. As a pre-requisite, define and
> globalize the qemu_inet_opts.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
>
> Makefile.objs | 2 +-
> qemu-config.c | 31 +++++++++++++++++++++++++++++++
> qemu-sockets.c | 42 ++++++------------------------------------
> qemu_socket.h | 1 +
> 4 files changed, 39 insertions(+), 37 deletions(-)
Making the option list global sounds fine, but I don't think it should
be moved to qemu-config.c or added to vm_config_groups, which is
generally used for command line options and config file entries. At
least I can't imagine a command line option -inet would be very useful.
Kevin
next prev parent reply other threads:[~2012-09-18 12:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 15:21 [Qemu-devel] [RFC v7 0/5] GlusterFS support in QEMU - v7 Bharata B Rao
2012-09-17 15:22 ` [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static Bharata B Rao
2012-09-18 12:47 ` Kevin Wolf [this message]
2012-09-18 12:57 ` Paolo Bonzini
2012-09-20 5:57 ` Bharata B Rao
2012-09-17 15:23 ` [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port Bharata B Rao
2012-09-18 13:22 ` Kevin Wolf
2012-09-18 13:31 ` Paolo Bonzini
2012-09-18 14:08 ` Kevin Wolf
2012-09-20 6:30 ` Bharata B Rao
2012-09-20 6:51 ` Kevin Wolf
2012-09-17 15:24 ` [Qemu-devel] [PATCH v7 3/5] aio: Fix qemu_aio_wait() to maintain correct walking_handlers count Bharata B Rao
2012-09-17 15:25 ` [Qemu-devel] [PATCH v7 4/5] configure: Add a config option for GlusterFS as block backend Bharata B Rao
2012-09-17 15:26 ` [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU " Bharata B Rao
2012-09-18 14:01 ` Kevin Wolf
2012-09-20 6:41 ` Bharata B Rao
2012-09-20 7:53 ` Paolo Bonzini
2012-09-20 8:20 ` Paolo Bonzini
2012-09-20 9:12 ` Bharata B Rao
2012-09-20 9:14 ` Paolo Bonzini
2012-09-20 9:34 ` Kevin Wolf
2012-09-20 15:08 ` Paolo Bonzini
2012-09-21 3:50 ` Bharata B Rao
2012-09-21 8:23 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50586D7F.8060307@redhat.com \
--to=kwolf@redhat.com \
--cc=aavati@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=amarts@redhat.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vbellur@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.