From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDyqi-0007ZY-Kp
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 10:32:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDyqb-0005eT-Pv
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 10:32:28 -0400
Message-ID: <505885F1.7000406@suse.de>
Date: Tue, 18 Sep 2012 16:32:17 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339086183-1356-1-git-send-email-afaerber@suse.de>
	<5058693B.9020103@msgid.tls.msk.ru>
In-Reply-To: <5058693B.9020103@msgid.tls.msk.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix
 target path in generated dependency file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, qemu-stable@nongnu.org

Am 18.09.2012 14:29, schrieb Michael Tokarev:
> Has it been applied to anything?  I don't think so.
> Is it still needed?

Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.

/-F

>=20
> Thanks,
>=20
> /mjt
>=20
> On 07.06.2012 20:23, Andreas F=C3=A4rber wrote:
>> config-devices.mak.d is included from Makefile.target, i.e. from insid=
e
>> the *-softmmu/ directory. It included the directory path, so never
>> applied to the actual config-devices.mak. Symptoms were spurious
>> dependency issues with default-configs/pci.mak.
>>
>> Fix by using `basename` to strip the directory path.
>>
>> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>> ---
>>  Seems I forgot to send this out before 1.1...
>>
>>  scripts/make_device_config.sh |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/make_device_config.sh b/scripts/make_device_confi=
g.sh
>> index 5d14885..0778fe2 100644
>> --- a/scripts/make_device_config.sh
>> +++ b/scripts/make_device_config.sh
>> @@ -25,4 +25,4 @@ done
>>  process_includes $src > $dest
>> =20
>>  cat $src $all_includes | grep -v '^include' > $dest
>> -echo "$1: $all_includes" > $dep
>> +echo "`basename $1`: $all_includes" > $dep
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg