All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wido den Hollander <wido@widodh.nl>
To: Andrey Korolyov <andrey@xdel.ru>
Cc: Guido Winkelmann <guido-ceph@thisisnotatest.de>,
	ceph-devel@vger.kernel.org
Subject: Re: enabling cephx by default
Date: Tue, 18 Sep 2012 17:12:06 +0200	[thread overview]
Message-ID: <50588F46.7010907@widodh.nl> (raw)
In-Reply-To: <CABYiri8-hYEw4aBjB+GbEYDj2btt-qTCeYxU6_DVHWC-tVTNGQ@mail.gmail.com>



On 18-09-12 15:54, Andrey Korolyov wrote:
> On Tue, Sep 18, 2012 at 5:34 PM, Andrey Korolyov <andrey@xdel.ru> wrote:
>> On Tue, Sep 18, 2012 at 4:37 PM, Guido Winkelmann
>> <guido-ceph@thisisnotatest.de> wrote:
>>> Am Dienstag, 11. September 2012, 17:25:49 schrieben Sie:
>>>> The next stable release will have cephx authentication enabled by default.
>>>
>>> Hm, that could be a problem for me. I have tried multiple times to get cephx
>>> working in the past, without lasting success. (I cannot recall at the moment
>>> what the problem was the last time around, but it was probably qemu/libvirt.)
>>
>> BTW, libvirt 0.10.x has a broken cephx support somehow. It forms same
>> string for -drive as 0.9x(at least in a log) but failing to pass
>> authentication same moment.
>>
> Please nevermind, I have build incorrect regex for log parsing previously.
> https://www.redhat.com/archives/libvirt-users/2012-September/msg00082.html
>>>

Hmmm, did I break that? With this commit: 
http://www.libvirt.org/git/?p=libvirt.git;a=commitdiff;h=ccb94785007d33365d49dd566e194eb0a022148d

The full code can be found here: 
http://www.libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_command.c;h=94b2919f52d52c14e364aac44fe130e9dbaf97ae;hb=ccb94785007d33365d49dd566e194eb0a022148d#l1733

The commit above only adds a else statement where it adds 
auth_supported=none when disk->username was not set.

Wido

>>> IMHO, the documentation badly needs a high-level overview for cephx (or maybe
>>> I just haven't found it yet); what it does, what dangers it protects you from
>>> and how it achieves that.
>>>
>>>          Guido
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

      reply	other threads:[~2012-09-18 15:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12  0:25 enabling cephx by default Sage Weil
2012-09-12 14:55 ` Wido den Hollander
2012-09-18 12:37 ` Guido Winkelmann
2012-09-18 13:34   ` Andrey Korolyov
2012-09-18 13:54     ` Andrey Korolyov
2012-09-18 15:12       ` Wido den Hollander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50588F46.7010907@widodh.nl \
    --to=wido@widodh.nl \
    --cc=andrey@xdel.ru \
    --cc=ceph-devel@vger.kernel.org \
    --cc=guido-ceph@thisisnotatest.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.