All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Linux Wireless List" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: remove obselete comment for .sched_scan_stop() callback
Date: Tue, 18 Sep 2012 18:20:18 +0200	[thread overview]
Message-ID: <50589F42.9060608@broadcom.com> (raw)
In-Reply-To: <1347964664.4283.0.camel@jlt4.sipsolutions.net>

On 09/18/2012 12:37 PM, Johannes Berg wrote:
> On Tue, 2012-09-18 at 10:59 +0200, Arend van Spriel wrote:
>> The kerneldoc comment for .sched_scan_stop() callback describes a
>> driver_initiated flag, but the interface does not hold such a flag.
>>
>> Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
>> Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
>> Signed-off-by: Arend van Spriel <arend@broadcom.com>
>> ---
>> Hi Johannes,
>>
>> Was working on scheduled scan support for brcmfmac and got a little
>> confused about .sched_scan_stop() documentation. Not sure if this
>> was stale documentation.
>
> Yes I believe this was some sort of circular call that we removed
> (driver calls stop, cfg80211 tells driver it itself stopped??)

I can come up with a scenario, where scheduled scan related cleanup is 
done in sched_scan_stop and needs different behaviour when initiated by 
driver as opposed to user-space initiated. However, it feels awkward so 
good riddance.

> I'll apply this (and fix the typo ("obsolete") in the subject)
>
> johannes

Thanks (and thanks for fixing the subject ;-) ).

Gr. AvS



      reply	other threads:[~2012-09-18 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  8:59 [PATCH] cfg80211: remove obselete comment for .sched_scan_stop() callback Arend van Spriel
2012-09-18 10:37 ` Johannes Berg
2012-09-18 16:20   ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50589F42.9060608@broadcom.com \
    --to=arend@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.