From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: What are you doing if the TX buffer overflows? Date: Tue, 18 Sep 2012 21:01:25 +0200 Message-ID: <5058C505.6020605@pengutronix.de> References: <2478881.znSzbTXnK5@uschi> <505777BC.3000705@hartkopp.net> <5058659E.2010804@grandegger.com> <50586A50.5060300@pengutronix.de> <50586DE4.9020707@grandegger.com> <50587058.7090703@pengutronix.de> <50587987.3070308@grandegger.com> <50587A4F.5060105@pengutronix.de> <5058C28A.5030300@grandegger.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig46F6F2D012C20D69FA9C9823" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:57832 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862Ab2IRTBg (ORCPT ); Tue, 18 Sep 2012 15:01:36 -0400 In-Reply-To: <5058C28A.5030300@grandegger.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Wolfgang Grandegger Cc: Oliver Hartkopp , =?ISO-8859-1?Q?Heinz-J=FCrg?= =?ISO-8859-1?Q?en_Oertel?= , "linux-can@vger.kernel.org" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig46F6F2D012C20D69FA9C9823 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/18/2012 08:50 PM, Wolfgang Grandegger wrote: > On 09/18/2012 03:42 PM, Marc Kleine-Budde wrote: >> On 09/18/2012 03:39 PM, Wolfgang Grandegger wrote: >>> On 09/18/2012 03:00 PM, Marc Kleine-Budde wrote: >>>> On 09/18/2012 02:49 PM, Wolfgang Grandegger wrote: >>>> [...] >>>> >>>>>> We have several customers who asked how to abort pending TX messag= es, >>>>>> too. Which involves: >>>>>> a) clear the TX-queue in Linux >>>>>> b) clear queue in hardware >>>>>> c) abort currently transmitting CAN frame >>>>>> >>>>>> I think c) would be a usecase of its own, too. >>>>> >>>>> I think you need c) for b), at least for some controllers. These >>>> >>>> Yes, if it's a hardware limitation so be it. But if we design an >>>> interface it should support "clear everything" (a+b+c), but also jus= t >>>> only c. >>> >>> Yes, that you be nice. The only portable "clear everything" (a+b+c) I= >>> see is "ifconfig down -> up". This also answers you other related mai= l. >>> >>> What do people really want/need and why? This is still not clear to m= e. >>> More input would be nice. >> >> Heinz-J=FCrgen uses abort current TX Message on SJA1000, can you give = us >> more insight? I've talked to customers, e.g. they want to abort the >> current frame if it takes "too long" to send it, because the frames CA= N >> id priority is too low. >=20 > What we could implement rather easily is a "tx-abort-last" or > "tx-abort-all" netlink command. As this command does not make sense whe= n > more than one message is pending I'm in favor of "tx-abort-last". I like to have both commands. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig46F6F2D012C20D69FA9C9823 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBYxQwACgkQjTAFq1RaXHO2+gCeK2ik2ZaIXFlme2mPt8TsEt8L pHUAnifHAigA3eegZSIQRnIhHVTSRTVU =kL8g -----END PGP SIGNATURE----- --------------enig46F6F2D012C20D69FA9C9823--