From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TE7w7-0005RT-Qs
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 20:14:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TE7w6-0001ob-Sk
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 20:14:39 -0400
Received: from mail-qa0-f52.google.com ([209.85.216.52]:33218)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TE7w6-0001oP-Om
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 20:14:38 -0400
Received: by qabg14 with SMTP id g14so498918qab.4
	for <qemu-devel@nongnu.org>; Tue, 18 Sep 2012 17:14:38 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50590E69.3020806@twiddle.net>
Date: Tue, 18 Sep 2012 17:14:33 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1347224784-19472-1-git-send-email-rth@twiddle.net>
	<1347224784-19472-11-git-send-email-rth@twiddle.net>
	<5058D717.8070600@suse.de>
In-Reply-To: <5058D717.8070600@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception
	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

On 09/18/2012 01:18 PM, Alexander Graf wrote:
>> -    /* remember what pgm exeption this was */
>> +    /* Remember what pgm exeption this was.  */
>>       tmp = tcg_const_i32(code);
>>       tcg_gen_st_i32(tmp, cpu_env, offsetof(CPUS390XState, int_pgm_code));
>>       tcg_temp_free_i32(tmp);
>>   -    tmp = tcg_const_i32(ilc);
>> +    tmp = tcg_const_i32(s->next_pc - s->pc);
> 
> Mind to explain this one?

ILC = the size of the insn.  Rather than passing ILC around into
gen_program_exception, get it back from the s->next_pc value that
we stored into DisasContext.


r~