Re: [PATCH v2] mbuf: fix bulk allocation when debug enabled

[Thomas Monjalon <thomas@monjalon.net>]

10/05/2017 16:42, Olivier Matz:
> Hi,
> 
> On Sat, 06 May 2017 10:26:49 +0300, Gregory Etelson <gregory@weka.io> wrote:
> > The debug assertions when allocating a raw mbuf are not correct since
> > commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"),
> > which triggers a panic when using this function in debug mode
> > 
> 
> Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool")
> 
> > Signed-off-by: Gregory Etelson <gregory@weka.io>
> > ---
> >  lib/librte_mbuf/rte_mbuf.h | 25 ++++++++++++-------------
> >  1 file changed, 12 insertions(+), 13 deletions(-)
> > 
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index 9097f18..05b8300 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -788,6 +788,13 @@ rte_mbuf_refcnt_set(struct rte_mbuf *m, uint16_t new_value)
> >  void
> >  rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header);
> >  
> > +#define MBUF_RAW_ALLOC_CHECK(m_) do {				\
> > +	RTE_ASSERT(rte_mbuf_refcnt_read(m_) == 1);		\
> > +	RTE_ASSERT(m_->next == NULL);				\
> > +	RTE_ASSERT(m_->nb_segs == 1);				\
> > +	__rte_mbuf_sanity_check(m_, 0);				\
> > +} while (0)
> > +
> 
> Few nits:
> - maybe 'm_' could be 'm'
> - some parenthesis could be added for safety
> 
> Thomas, I know you're in hurry for 17.05, I think this fix should
> go in. If you want, I can send a v3 with this small changes if you
> need it now.

Yes, please a quick v3 would be appreciated.
Thanks