From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: use IRQF_ONESHOT for twl6040
Date: Wed, 19 Sep 2012 09:19:36 +0300 [thread overview]
Message-ID: <505963F8.5000804@ti.com> (raw)
In-Reply-To: <20120919013238.GA14408@localhost>
On 09/19/2012 04:32 AM, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT.
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> drivers/mfd/twl6040-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/drivers/mfd/twl6040-core.c 2012-09-18 08:22:36.381180459 +0800
> +++ linux/drivers/mfd/twl6040-core.c 2012-09-19 09:27:15.947969313 +0800
> @@ -584,7 +584,7 @@ static int __devinit twl6040_probe(struc
> goto irq_init_err;
>
> ret = request_threaded_irq(twl6040->irq_base + TWL6040_IRQ_READY,
> - NULL, twl6040_naudint_handler, 0,
> + NULL, twl6040_naudint_handler, IRQF_ONESHOT,
> "twl6040_irq_ready", twl6040);
> if (ret) {
> dev_err(twl6040->dev, "READY IRQ request failed: %d\n",
>
next prev parent reply other threads:[~2012-09-19 6:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 1:30 [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Fengguang Wu
2012-09-19 1:32 ` [PATCH] mfd: use IRQF_ONESHOT for twl6040 Fengguang Wu
2012-09-19 6:19 ` Peter Ujfalusi [this message]
2012-09-19 1:41 ` [PATCH] mfd: use IRQF_ONESHOT for max8925 Fengguang Wu
2012-09-19 11:26 ` [PATCH] mfd: use IRQF_ONESHOT for 88pm860x Samuel Ortiz
2012-09-19 23:24 ` [PATCH] mfd: arizona: use IRQF_ONESHOT Fengguang Wu
2012-09-20 0:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505963F8.5000804@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.