From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TELMM-0001y1-78 for qemu-devel@nongnu.org; Wed, 19 Sep 2012 10:34:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TELMG-0006S0-Sb for qemu-devel@nongnu.org; Wed, 19 Sep 2012 10:34:38 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:36859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TELMG-0006R4-MG for qemu-devel@nongnu.org; Wed, 19 Sep 2012 10:34:32 -0400 Received: by pbbrp12 with SMTP id rp12so2594538pbb.4 for ; Wed, 19 Sep 2012 07:34:32 -0700 (PDT) Sender: Richard Henderson Message-ID: <5059D7F5.5050404@twiddle.net> Date: Wed, 19 Sep 2012 07:34:29 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1347224784-19472-1-git-send-email-rth@twiddle.net> <1347224784-19472-11-git-send-email-rth@twiddle.net> <5058D717.8070600@suse.de> <50590E69.3020806@twiddle.net> <385292C5-4C9E-43FD-8407-1322CE671AD7@suse.de> In-Reply-To: <385292C5-4C9E-43FD-8407-1322CE671AD7@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 010/126] target-s390: Reorg exception handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , qemu-devel@nongnu.org On 09/19/2012 06:02 AM, Alexander Graf wrote: > Richard, please double-check all the ilc passing again with the spec. I'll look again. But I do recall that the spec is consistent in placing a 3-bit field (values 1-3) shifted one bit left into the larger 32-bit field, so that in essence the value is always the real instruction length. However, qemu was not consistent in performing that multiplication. So there will be some place that gets changed because of this. Frankly I think it would be least confusing to always manipulate the full instruction length and never explicitly perform the multiply. r~