From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:23111 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531Ab2ISPSO (ORCPT ); Wed, 19 Sep 2012 11:18:14 -0400 Received: from eusync3.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MAL005SMRV6SX10@mailout3.w1.samsung.com> for linux-media@vger.kernel.org; Wed, 19 Sep 2012 16:18:42 +0100 (BST) Received: from [106.116.147.32] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MAL006W2RUBV500@eusync3.samsung.com> for linux-media@vger.kernel.org; Wed, 19 Sep 2012 16:18:12 +0100 (BST) Message-id: <5059E233.4030006@samsung.com> Date: Wed, 19 Sep 2012 17:18:11 +0200 From: Sylwester Nawrocki MIME-version: 1.0 To: Hans Verkuil Cc: linux-media@vger.kernel.org, Pawel Osciak , Marek Szyprowski , Hans Verkuil Subject: Re: [RFCv1 PATCH 1/6] videobuf2-core: move num_planes from vb2_buffer to vb2_queue. References: <1348065460-1624-1-git-send-email-hverkuil@xs4all.nl> <9e4acd70e02bb67e6e7af0c236c69af27108e4fa.1348064901.git.hans.verkuil@cisco.com> In-reply-to: <9e4acd70e02bb67e6e7af0c236c69af27108e4fa.1348064901.git.hans.verkuil@cisco.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, On 09/19/2012 04:37 PM, Hans Verkuil wrote: > From: Hans Verkuil > > It's a queue-global value, so keep it there rather than with the > buffer struct. I would prefer not doing this. It makes the path to variable number of per buffer planes more difficult. Regards, Sylwester