All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 1/2 v2] ismounted fix
Date: Wed, 19 Sep 2012 18:00:30 +0200	[thread overview]
Message-ID: <5059EC1E.3070604@redhat.com> (raw)
In-Reply-To: <20120919135906.GE31860-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Am 19.09.2012 15:59, schrieb Vivek Goyal:
> On Mon, Sep 17, 2012 at 06:01:03PM +0800, Dave Young wrote:
>>
>> ismounted handles both find-by-dev and find-by-mnt, but there's two issues:
>> 1. for find-by-dev, it use readlink to get the canonical dev name, but
>>    lvm is different with other devices, the canonical name for lvm devices
>>    are symlinks like /dev/mapper/vg-lv00
>> 2. for nfs mounting, just use [ -b $dev ] is not enough, it need being handled
>>    seperately.
>>
>> Per Karel Zak's suggestion, findmnt util is suitable for this purpose, it
>> handles these cases well, so just use findmnt instead of implement all the
>> logic by ourselves. Thanks, Karel.
> 
> This patch looks reasonable to me. Harald, are you fine with it?
> 
> Vivek

Yes. Looks good!

      parent reply	other threads:[~2012-09-19 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17 10:01 [PATCH 1/2 v2] ismounted fix Dave Young
     [not found] ` <20120917100103.GA18640-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2012-09-19 13:59   ` Vivek Goyal
     [not found]     ` <20120919135906.GE31860-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-19 16:00       ` Harald Hoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5059EC1E.3070604@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.