From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Date: Wed, 19 Sep 2012 17:08:05 +0000 Subject: Re: [patch] iio: dac/ad5755: signedness bug in ad5755_setup_pdata() Message-Id: <5059FBF5.7070703@metafoo.de> List-Id: References: <20120919062700.GA28864@elgon.mountain> In-Reply-To: <20120919062700.GA28864@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Jonathan Cameron , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org On 09/19/2012 08:27 AM, Dan Carpenter wrote: > We need "ret" to be signed for the error handling to work correctly. > > Signed-off-by: Dan Carpenter Thanks, Acked-by: Lars-Peter Clausen > > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c > index e6dbe5f..5db3506 100644 > --- a/drivers/iio/dac/ad5755.c > +++ b/drivers/iio/dac/ad5755.c > @@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev, > const struct ad5755_platform_data *pdata) > { > struct ad5755_state *st = iio_priv(indio_dev); > - unsigned int ret; > unsigned int val; > unsigned int i; > + int ret; > > if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE || > pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ || > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-038.synserver.de ([212.40.185.38]:1257 "EHLO smtp-out-038.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756429Ab2ISRHZ (ORCPT ); Wed, 19 Sep 2012 13:07:25 -0400 Message-ID: <5059FBF5.7070703@metafoo.de> Date: Wed, 19 Sep 2012 19:08:05 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Dan Carpenter CC: Jonathan Cameron , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] iio: dac/ad5755: signedness bug in ad5755_setup_pdata() References: <20120919062700.GA28864@elgon.mountain> In-Reply-To: <20120919062700.GA28864@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/19/2012 08:27 AM, Dan Carpenter wrote: > We need "ret" to be signed for the error handling to work correctly. > > Signed-off-by: Dan Carpenter Thanks, Acked-by: Lars-Peter Clausen > > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c > index e6dbe5f..5db3506 100644 > --- a/drivers/iio/dac/ad5755.c > +++ b/drivers/iio/dac/ad5755.c > @@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev, > const struct ad5755_platform_data *pdata) > { > struct ad5755_state *st = iio_priv(indio_dev); > - unsigned int ret; > unsigned int val; > unsigned int i; > + int ret; > > if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE || > pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ || > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html