All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC 2/7] image.bbclass: run postinst scripts once, at rootfs time
Date: Wed, 19 Sep 2012 20:12:54 +0300	[thread overview]
Message-ID: <5059FD16.6070109@intel.com> (raw)
In-Reply-To: <CAJTo0Laae2ZaE+8E_Co3rUQbYtQOtK41wGtBi8sRdWDWnXzjDg@mail.gmail.com>



On 09/19/2012 06:50 PM, Burton, Ross wrote:
> On 19 September 2012 16:45, Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
>> I'm a little confused here... Technically, when the postprocess hooks
>> are executed all the postinstall scripts were already executed. Ideally,
>> the run-once scripts are created from inside the postinst scriptlets
>> themselves. So, I don't really understand why using the postprocess hook
>> isn't safe. Can you please elaborate?
> 
> My concern (and it's just a hunch) is that there could be a
> post-process hook running before the intercepts are run which could be
> expecting the post install phase to have been completed.  With
> intercepts a portion of the post-install phase is happening later than
> they previously did, so they haven't completely been ran yet.
I see your point now... The only place we could do it in image.bbclass
is immediately after rootfs_${IMAGE_PKGTYPE}_do_rootfs in do_rootfs()
function. But then we fall into the same issue you mentioned. The
post-process hooks would be executed before the intercept scripts...

The alternative would be to use the post-install hooks
(ROOTFS_POSTINSTALL_COMMAND) instead of post-process. These are executed
before the post-process hooks.

Thanks,
Laurentiu

> 
> Ross
> 



  reply	other threads:[~2012-09-19 17:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 11:49 [RFC 0/7] Postinstall improvements Laurentiu Palcu
2012-09-19 11:49 ` [RFC 1/7] gtk+: enable gtk+-native Laurentiu Palcu
2012-09-19 11:49 ` [RFC 2/7] image.bbclass: run postinst scripts once, at rootfs time Laurentiu Palcu
2012-09-19 15:14   ` Burton, Ross
2012-09-19 15:45     ` Laurentiu Palcu
2012-09-19 15:50       ` Burton, Ross
2012-09-19 17:12         ` Laurentiu Palcu [this message]
2012-09-20 12:25   ` Richard Purdie
2012-09-19 11:49 ` [RFC 3/7] rootfs generation: export two new variables to postinst scriptlets Laurentiu Palcu
2012-09-19 11:49 ` [RFC 4/7] gtk-icon-cache: run the icon generation at rootfs time Laurentiu Palcu
2012-09-19 13:28   ` Khem Raj
2012-09-19 13:38     ` Burton, Ross
2012-09-19 15:26       ` Laurentiu Palcu
2012-09-19 11:49 ` [RFC 5/7] gdk-pixbuf: generate the pixbuf loader's cache ar " Laurentiu Palcu
2012-09-19 13:30   ` Khem Raj
2012-09-19 15:29     ` Laurentiu Palcu
2012-09-19 11:49 ` [RFC 6/7] sato-icon-theme: make use of the gtk-icon-cache postinst scriptlet Laurentiu Palcu
2012-09-19 13:36   ` Burton, Ross
2012-09-19 15:30     ` Laurentiu Palcu
2012-09-19 11:49 ` [RFC 7/7] postinst changes: bump PR to all recipes inheriting gnome and gtk-icon-cache Laurentiu Palcu
     [not found] ` <CALbNGRTCyvfZFYHx6bKV8oVDJWH3X0tj1DHSJm9CkvT4xY2f7A@mail.gmail.com>
     [not found]   ` <5059E5C3.2080603@intel.com>
2012-09-20 15:38     ` [RFC 0/7] Postinstall improvements Andreas Müller
2012-09-20 16:12       ` Andreas Müller
2012-09-20 18:15         ` Laurentiu Palcu
2012-09-20 20:54           ` Martin Jansa
2012-09-26  7:09         ` Laurentiu Palcu
2012-09-26  7:41           ` Andreas Müller
2012-10-03 23:37             ` Andreas Müller
2012-10-04 19:16               ` Andreas Müller
2012-10-05  6:39                 ` Laurentiu Palcu
2012-10-05 20:43                   ` Andreas Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5059FD16.6070109@intel.com \
    --to=laurentiu.palcu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.