From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
linaro-dev@lists.linaro.org, patches@linaro.org, lenb@kernel.org
Subject: Re: [PATCH 1/3] cpuidle : remove unused ref count function
Date: Wed, 19 Sep 2012 21:56:16 +0200 [thread overview]
Message-ID: <505A2360.7000500@linaro.org> (raw)
In-Reply-To: <201209192149.38164.rjw@sisk.pl>
On 09/19/2012 09:49 PM, Rafael J. Wysocki wrote:
> On Wednesday, September 19, 2012, Daniel Lezcano wrote:
>> These two functions are never used.
> This is not the case. pm_genpd_attach_cpuidle() and
> pm_genpd_detach_cpuidle() use them.
>
> Please be more careful.
Oops, sorry.
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> drivers/cpuidle/driver.c | 29 +----------------------------
>> include/linux/cpuidle.h | 4 ----
>> 2 files changed, 1 insertions(+), 32 deletions(-)
>>
>> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
>> index 58bf3b1..40cd3f3 100644
>> --- a/drivers/cpuidle/driver.c
>> +++ b/drivers/cpuidle/driver.c
>> @@ -16,7 +16,6 @@
>>
>> static struct cpuidle_driver *cpuidle_curr_driver;
>> DEFINE_SPINLOCK(cpuidle_driver_lock);
>> -int cpuidle_driver_refcount;
>>
>> static void __cpuidle_register_driver(struct cpuidle_driver *drv)
>> {
>> @@ -90,34 +89,8 @@ void cpuidle_unregister_driver(struct cpuidle_driver *drv)
>> }
>>
>> spin_lock(&cpuidle_driver_lock);
>> -
>> - if (!WARN_ON(cpuidle_driver_refcount > 0))
>> - cpuidle_curr_driver = NULL;
>> -
>> + cpuidle_curr_driver = NULL;
>> spin_unlock(&cpuidle_driver_lock);
>> }
>>
>> EXPORT_SYMBOL_GPL(cpuidle_unregister_driver);
>> -
>> -struct cpuidle_driver *cpuidle_driver_ref(void)
>> -{
>> - struct cpuidle_driver *drv;
>> -
>> - spin_lock(&cpuidle_driver_lock);
>> -
>> - drv = cpuidle_curr_driver;
>> - cpuidle_driver_refcount++;
>> -
>> - spin_unlock(&cpuidle_driver_lock);
>> - return drv;
>> -}
>> -
>> -void cpuidle_driver_unref(void)
>> -{
>> - spin_lock(&cpuidle_driver_lock);
>> -
>> - if (!WARN_ON(cpuidle_driver_refcount <= 0))
>> - cpuidle_driver_refcount--;
>> -
>> - spin_unlock(&cpuidle_driver_lock);
>> -}
>> diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
>> index 279b1ea..5abf62b 100644
>> --- a/include/linux/cpuidle.h
>> +++ b/include/linux/cpuidle.h
>> @@ -145,8 +145,6 @@ extern void disable_cpuidle(void);
>> extern int cpuidle_idle_call(void);
>> extern int cpuidle_register_driver(struct cpuidle_driver *drv);
>> extern struct cpuidle_driver *cpuidle_get_driver(void);
>> -extern struct cpuidle_driver *cpuidle_driver_ref(void);
>> -extern void cpuidle_driver_unref(void);
>> extern void cpuidle_unregister_driver(struct cpuidle_driver *drv);
>> extern int cpuidle_register_device(struct cpuidle_device *dev);
>> extern void cpuidle_unregister_device(struct cpuidle_device *dev);
>> @@ -169,8 +167,6 @@ static inline int cpuidle_idle_call(void) { return -ENODEV; }
>> static inline int cpuidle_register_driver(struct cpuidle_driver *drv)
>> {return -ENODEV; }
>> static inline struct cpuidle_driver *cpuidle_get_driver(void) {return NULL; }
>> -static inline struct cpuidle_driver *cpuidle_driver_ref(void) {return NULL; }
>> -static inline void cpuidle_driver_unref(void) {}
>> static inline void cpuidle_unregister_driver(struct cpuidle_driver *drv) { }
>> static inline int cpuidle_register_device(struct cpuidle_device *dev)
>> {return -ENODEV; }
>>
>
> _______________________________________________
> linaro-dev mailing list
> linaro-dev@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-dev
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-09-19 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 17:22 [PATCH 1/3] cpuidle : remove unused ref count function Daniel Lezcano
2012-09-19 17:22 ` [PATCH 2/3] cpuidle : rename function name "__cpuidle_register_driver" Daniel Lezcano
2012-09-19 19:51 ` Rafael J. Wysocki
2012-09-19 20:00 ` Daniel Lezcano
2012-09-19 17:22 ` [PATCH 3/3] cpuidle : remove trailing carriage return Daniel Lezcano
2012-09-19 20:16 ` Rafael J. Wysocki
2012-09-19 19:49 ` [PATCH 1/3] cpuidle : remove unused ref count function Rafael J. Wysocki
2012-09-19 19:56 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505A2360.7000500@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.