From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Durgin Subject: Re: [PATCH 9/9] rbd: activate v2 image support Date: Wed, 19 Sep 2012 12:57:11 -0700 Message-ID: <505A2397.4070106@inktank.com> References: <504A6273.7030807@inktank.com> <504A63FC.1080005@inktank.com> <505A236C.9000103@hq.newdream.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:36971 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851Ab2IST5O (ORCPT ); Wed, 19 Sep 2012 15:57:14 -0400 Received: by pbbrr13 with SMTP id rr13so3273161pbb.19 for ; Wed, 19 Sep 2012 12:57:14 -0700 (PDT) In-Reply-To: <505A236C.9000103@hq.newdream.net> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Alex Elder Cc: ceph-devel@vger.kernel.org On 09/19/2012 12:56 PM, Josh Durgin wrote: > Until layering is implemented, this should report an > error if features is not 0. Layering is feature bit 1. > > You can copy the userspace header from ceph.git in > src/include/librbd/features.h to use the same feature macros. err, that's src/include/rbd/features.h > On 09/07/2012 02:15 PM, Alex Elder wrote: >> Now that v2 images support is fully implemented, have >> rbd_dev_v2_probe() return 0 to indicate a successful probe. >> >> Signed-off-by: Alex Elder >> --- >> drivers/block/rbd.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >> index b466393..2f83f71 100644 >> --- a/drivers/block/rbd.c >> +++ b/drivers/block/rbd.c >> @@ -2973,7 +2973,7 @@ static int rbd_dev_v2_probe(struct rbd_device >> *rbd_dev) >> dout("discovered version 2 image, header name is %s\n", >> rbd_dev->header_name); >> >> - return -ENOTSUPP; >> + return 0; >> out_err: >> kfree(rbd_dev->header_name); >> rbd_dev->header_name = NULL; >> >