From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga
Date: Thu, 20 Sep 2012 07:43:17 +0200
Message-ID: <505AACF5.6080703@redhat.com>
References: <1347961897-28554-1-git-send-email-kraxel@redhat.com> <CAAu8pHvr-GA7C3ky1kPiMC2XJornwP-1WR1Z-KHZsODyAA1p-g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:5112 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751767Ab2ITFnW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 20 Sep 2012 01:43:22 -0400
In-Reply-To: <CAAu8pHvr-GA7C3ky1kPiMC2XJornwP-1WR1Z-KHZsODyAA1p-g@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  Hi,

>> +    vbe_ioport_write_index(&d->vga, 0, index);
>> +    return vbe_ioport_read_data(&d->vga, 0);
> 
> These functions are only available with CONFIG_BOCHS_VBE #defined, so
> this code should be conditional as well.
> 
> But building without CONFIG_BOCHS_VBE is not very useful since it's
> used by the BIOS and there's no display output without it IIRC.

Well, text mode is still there, but no (by modern standards) useful
graphics modes, only standard vga ones (i.e. up to 800x600 @ 256 colors
or something like that).

I guess it is better to just remove CONFIG_BOCHS_VBE, /me goes prepare a
patch.

cheers,
  Gerd