From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEaU1-0001L4-5C for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:43:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEaTx-0004yj-8y for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:43:33 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:48109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEaTx-0004ye-14 for qemu-devel@nongnu.org; Thu, 20 Sep 2012 02:43:29 -0400 Message-ID: <505ABB0E.9030305@msgid.tls.msk.ru> Date: Thu, 20 Sep 2012 10:43:26 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1348062086-23490-1-git-send-email-mjt@msgid.tls.msk.ru> <505ABA90.6070002@redhat.com> In-Reply-To: <505ABA90.6070002@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Alon Levy , qemu-devel@nongnu.org, Dunrong Huang On 20.09.2012 10:41, Gerd Hoffmann wrote: > On 09/19/12 15:41, Michael Tokarev wrote: >> This cleans up two additions of almost the same code in commits >> 511b13e2c9 and ccc2960d654. While at it, make error paths >> consistent (always use 'break' instead of 'return'). > > Other way around: should be 'return' not 'break'. In other, early-added, error-return places it is "break". For now it is irrelevant actually, since right after the switch we already have "return", so "break" is now the same as "return". For future it might not be the case. /mjt