From: Stefano Babic <sbabic@denx.de>
To: Simon Budig <simon.budig@kernelconcepts.de>
Cc: Stefano Babic <sbabic@denx.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] input: wrong irq requested in edt-ft5x06.c
Date: Thu, 20 Sep 2012 10:56:55 +0200 [thread overview]
Message-ID: <505ADA57.4060606@denx.de> (raw)
In-Reply-To: <505AD454.7060200@kernelconcepts.de>
On 20/09/2012 10:31, Simon Budig wrote:
> On 09/20/2012 10:18 AM, Stefano Babic wrote:
>> But they contain the same information, as the irq number can be
>> get easy from irq_pin with gpio_to_irq(). Having both, it is
>> possible to set them to different values, and this is wrong.
>
> gpio_to_irq is not available on all platforms. There was a
> discussion on that topic quite a while ago.
I missed this issue, thanks !
> Moving the irq setup code to the board file was the conclusion from
> that discussion.
Understood, thanks.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
prev parent reply other threads:[~2012-09-20 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 14:53 [PATCH] input: wrong irq requested in edt-ft5x06.c Stefano Babic
2012-09-19 16:58 ` Dmitry Torokhov
2012-09-20 8:18 ` Stefano Babic
2012-09-20 8:31 ` Simon Budig
2012-09-20 8:56 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505ADA57.4060606@denx.de \
--to=sbabic@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=simon.budig@kernelconcepts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.