From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <505AF205.6010206@siemens.com> Date: Thu, 20 Sep 2012 12:37:57 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Xenomai] [PATCH] Revert "ipipe: ipipe_request_irq(), ipipe_free_irq() are root-only services" List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe Gerum , Gilles Chanteperdrix Cc: Wolfgang Mauerer , Xenomai This reverts commit 073ff1e8045d0311b8cf390687c0ba3619681672. Both service are NOT just root-only services. E.g., rtdm_irq_request requires by specification support also over non-Linux contexts. Signed-off-by: Jan Kiszka --- We run all critical code under an I-pipe spin lock, so this restriction seems artificial. Nevertheless, I briefly checked if some arch has specific needs but didn't find any trace in core-3.5. Wolfgang, this already resolves the issue I mentioned regarding startup of RTnet NICs. kernel/ipipe/core.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/kernel/ipipe/core.c b/kernel/ipipe/core.c index 9898b92..23a2146 100644 --- a/kernel/ipipe/core.c +++ b/kernel/ipipe/core.c @@ -846,8 +846,6 @@ int ipipe_request_irq(struct ipipe_domain *ipd, unsigned long flags; int ret = 0; - ipipe_root_only(); - if (handler == NULL || (irq >= IPIPE_NR_XIRQS && !ipipe_virtual_irq_p(irq))) return -EINVAL; @@ -881,8 +879,6 @@ void ipipe_free_irq(struct ipipe_domain *ipd, { unsigned long flags; - ipipe_root_only(); - spin_lock_irqsave(&__ipipe_lock, flags); if (ipd->irqs[irq].handler == NULL) -- 1.7.3.4