All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/6 V4] inode32/inode64 allocation changes
Date: Thu, 20 Sep 2012 09:51:30 -0400	[thread overview]
Message-ID: <505B1F62.30105@redhat.com> (raw)
In-Reply-To: <1348147961-7520-1-git-send-email-cmaiolino@redhat.com>

On 09/20/2012 09:32 AM, Carlos Maiolino wrote:
> This patch set adds inode64 as the default allocation mode, but also includes 2
> patches to remove duplicated code and another one to make inode32 able to be
> remounted.
> 
> NOTE: This patch has as dependency "Make inode64 a remountable option" patch.
> 
> V4 properly set pagf_metadata in patch 5
> 

Hi Carlos,

With that fix, this patchset looks good to me, thanks.

Reviewed-by: Brian Foster <bfoster@redhat.com>

Brian

> V3 has a better factoring of each patch goal, including other dchinner's
> suggestions in V2. 
> Also it contains a fix in how m_agirotor reset is made (patch 01) that I've
> found while doing tests with these patches.
> 
> Carlos Maiolino (6):
>   xfs: Fix m_agirotor reset during AG selection
>   xfs: make inode64 as the default allocation mode
>   xfs: reduce code duplication handling inode32/64 options
>   xfs: Fix mp->m_maxagi update during inode64 remount
>   xfs: add inode64->inode32 transition into xfs_set_inode32()
>   xfs: Make inode32 a remountable option
> 
>  fs/xfs/xfs_ialloc.c |   2 +-
>  fs/xfs/xfs_mount.c  |  43 +++----------------
>  fs/xfs/xfs_super.c  | 117 ++++++++++++++++++++++++++++++++++++++++------------
>  fs/xfs/xfs_super.h  |   2 +
>  4 files changed, 99 insertions(+), 65 deletions(-)
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2012-09-20 13:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 13:32 [PATCH 0/6 V4] inode32/inode64 allocation changes Carlos Maiolino
2012-09-20 13:32 ` [PATCH 1/6] xfs: Fix m_agirotor reset during AG selection Carlos Maiolino
2012-09-25  9:34   ` Christoph Hellwig
2012-09-26 20:19   ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 2/6] xfs: make inode64 as the default allocation mode Carlos Maiolino
2012-09-25  9:35   ` Christoph Hellwig
2012-09-26 20:20   ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 3/6] xfs: reduce code duplication handling inode32/64 options Carlos Maiolino
2012-09-25  9:36   ` Christoph Hellwig
2012-09-26 20:20   ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 4/6] xfs: Fix mp->m_maxagi update during inode64 remount Carlos Maiolino
2012-09-25  9:37   ` Christoph Hellwig
2012-09-25 13:33     ` Carlos Maiolino
2012-09-26 20:21   ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 5/6] xfs: add inode64->inode32 transition into xfs_set_inode32() Carlos Maiolino
2012-09-25  9:37   ` Christoph Hellwig
2012-09-26 20:21   ` Mark Tinguely
2012-09-20 13:32 ` [PATCH 6/6] xfs: Make inode32 a remountable option Carlos Maiolino
2012-09-25  9:37   ` Christoph Hellwig
2012-09-26 20:21   ` Mark Tinguely
2012-09-20 13:51 ` Brian Foster [this message]
2012-09-21 21:22 ` [PATCH 0/6 V4] inode32/inode64 allocation changes Ben Myers
2012-09-21 21:34   ` Ben Myers
2012-09-26 21:23 ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505B1F62.30105@redhat.com \
    --to=bfoster@redhat.com \
    --cc=cmaiolino@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.