From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond
Date: Thu, 20 Sep 2012 15:47:19 -0700 [thread overview]
Message-ID: <505B9CF7.2020000@twiddle.net> (raw)
In-Reply-To: <20120920220641.GD4457@ohm.aurel32.net>
On 09/20/2012 03:06 PM, Aurelien Jarno wrote:
>> > + if (TCG_TARGET_HAS_movcond_i64) {
>> > + tcg_gen_op6i_i64(INDEX_op_movcond_i64, ret, c1, c2, v1, v2, cond);
>> > + return;
> Minor nitpick: there is useless return here, and it's not present for
> movcond_i32.
>
Ah, right. I started to add a case for implementing movcond_i64
with movcond_i32, but didn't finish.
r~
next prev parent reply other threads:[~2012-09-20 22:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:23 [Qemu-devel] [PATCH 0/5] tcg: movcond Richard Henderson
2012-09-18 14:23 ` [Qemu-devel] [PATCH 1/5] tcg: Introduce movcond Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-20 22:06 ` Aurelien Jarno
2012-09-20 22:47 ` Richard Henderson [this message]
2012-09-18 14:23 ` [Qemu-devel] [PATCH 2/5] target-alpha: Use movcond Richard Henderson
2012-09-18 14:23 ` [Qemu-devel] [PATCH 3/5] tcg-i386: Implement movcond Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-18 14:23 ` [Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-20 22:04 ` Aurelien Jarno
2012-09-21 14:33 ` Richard Henderson
2012-09-21 14:52 ` Aurelien Jarno
2012-09-18 14:24 ` [Qemu-devel] [PATCH 5/5] tcg: Optimize two-address commutative operations Richard Henderson
2012-09-18 21:11 ` Aurelien Jarno
2012-09-18 21:11 ` [Qemu-devel] [PATCH 0/5] tcg: movcond Aurelien Jarno
2012-09-19 13:03 ` malc
2012-09-19 14:26 ` Richard Henderson
2012-09-19 19:07 ` Blue Swirl
2012-09-19 19:14 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B9CF7.2020000@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.