All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH V3] perf: Fix parallel build
Date: Thu, 20 Sep 2012 21:31:44 -0500	[thread overview]
Message-ID: <505BD190.40707@redhat.com> (raw)
In-Reply-To: <87392cyvpl.fsf@sejong.aot.lge.com>

Parallel builds of perf were failing for me on a 32p box, with:

    * new build flags or prefix
util/pmu.l:7:23: error: pmu-bison.h: No such file or directory

...

make: *** [util/pmu-flex.o] Error 1
make: *** Waiting for unfinished jobs....

This can pretty quickly be seen by adding a sleep in front of
the bison calls in tools/perf/Makefile and running make -j4 on a
smaller box i.e.:

	sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c

Adding the following dependencies fixes it for me.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

V2: Fix other bison dependency caught by Namhyung Kim <namhyung@kernel.org>, thanks.
V3: Add $(OUTPUT) to generated deps, thanks again.

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 35655c3..01325cd 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -221,13 +221,13 @@ export PERL_PATH
 FLEX = flex
 BISON= bison
 
-$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
+$(OUTPUT)util/parse-events-flex.c: util/parse-events.l $(OUTPUT)util/parse-events-bison.c
 	$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c
 
 $(OUTPUT)util/parse-events-bison.c: util/parse-events.y
 	$(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
 
-$(OUTPUT)util/pmu-flex.c: util/pmu.l
+$(OUTPUT)util/pmu-flex.c: util/pmu.l $(OUTPUT)util/pmu-bison.c
 	$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
 
 $(OUTPUT)util/pmu-bison.c: util/pmu.y



  parent reply	other threads:[~2012-09-21  2:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 23:53 [PATCH] perf: Fix parallel build Eric Sandeen
2012-09-21  0:24 ` Namhyung Kim
2012-09-21  1:08   ` Eric Sandeen
2012-09-21  1:12 ` [PATCH V2] " Eric Sandeen
2012-09-21  2:07   ` Namhyung Kim
2012-09-21  2:25     ` Eric Sandeen
2012-09-21  2:31     ` Eric Sandeen [this message]
2012-09-21  2:27       ` [PATCH V3] " Namhyung Kim
2012-09-27  4:25       ` [tip:perf/core] perf tools: " tip-bot for Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505BD190.40707@redhat.com \
    --to=sandeen@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.