From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH] can: mscan-mpc5xxx: fix return value check in mpc512x_can_get_clock() Date: Fri, 21 Sep 2012 09:14:08 +0200 Message-ID: <505C13C0.8090200@grandegger.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ngcobalt02.manitu.net ([217.11.48.102]:50438 "EHLO ngcobalt02.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819Ab2IUHPW (ORCPT ); Fri, 21 Sep 2012 03:15:22 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Wei Yongjun Cc: mkl@pengutronix.de, grant.likely@secretlab.ca, rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn, linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org On 09/21/2012 09:09 AM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function clk_get() returns ERR_PTR() > and never returns NULL pointer. The NULL test in the error > handling should be replaced with IS_ERR(). > > dpatch engine is used to auto generated this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Acked-by: Wolfgang Grandegger Thanks, Wolfgang.